Commit Graph

134 Commits

Author SHA1 Message Date
Jan Oberhauser
446c284540 👕 Fix lint issue 2021-05-15 00:36:41 -05:00
Jan Oberhauser
cb2887a8ab 🐛 Fix issue that expressions did not resolve for displayOptions 2021-05-15 00:28:51 -05:00
Ahsan Virani
2052cadce9 Add more frontend hooks (#1687)
*  add hook for nodecreatelist mount

*  add hook for nodeCreateList selectedTypeChanged

*  add hook for nodeCreateList nodeFilterChanged

*  add hook for nodeCreateList filteredNodeTypesComputed

*  add hook for nodeView.activeNodeChanged

*  add hook for credentialsEdit credentialTypeChanged

*  add hook for onDocumentationUrlClick

*  add hook for executionsList openDialog

*  add hook for execution open

*  add hook for credentialsList dialogVisibleChanged

*  add hook for workflowSettings

*  add hook for showMessage showError

*  add hook for nodeView createNodeActiveChanged

*  add hook for nodeView addNodeButton

*  cleanup

*  add hook for workflowRun runWorkflow

*  add hook for pushConnection executionFinished

*  add hook for runData.displayModeChanged

*  update nodeCreateList.nodeFilterChanged hook

*  update dataDisplay nodeTypeChanged hook

*  update dataDisplay nodeTypeChanged hook

*  update dataDisplay nodeTypeChanged hook

*  update error data in hooks

* update workflowRun runError hook

*  Minor improvements

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-05-05 19:46:33 -05:00
Mutasem Aldmour
0cb96d6caa 🐛 fix external links in sidemenu (#1720)
* fix admin link clickability

* fix bug when there are unsaved changes
2021-05-04 17:55:39 +02:00
Iván Ovejero
1d27a9e87e Improve node error handling (#1309)
* Add path mapping and response error interfaces

* Add error handling and throwing functionality

* Refactor error handling into a single function

* Re-implement error handling in Hacker News node

* Fix linting details

* Re-implement error handling in Spotify node

* Re-implement error handling in G Suite Admin node

* 🚧 create basic setup NodeError

* 🚧 add httpCodes

* 🚧 add path priolist

* 🚧 handle statusCode in error, adjust interfaces

* 🚧 fixing type issues w/Ivan

* 🚧 add error exploration

* 👔 fix linter issues

* 🔧 improve object check

* 🚧 remove path passing from NodeApiError

* 🚧 add multi error + refactor findProperty method

* 👔 allow any

* 🔧 handle multi error message callback

*  change return type of callback

*  add customCallback to MultiError

* 🚧 refactor to use INode

* 🔨 handle arrays, continue search after first null property found

* 🚫 refactor method access

* 🚧 setup NodeErrorView

*  change timestamp to Date.now

* 📚 Add documentation for methods and constants

* 🚧 change message setting

* 🚚 move NodeErrors to workflow

*  add new ErrorView for Nodes

* 🎨 improve error notification

* 🎨 refactor interfaces

*  add WorkflowOperationError, refactor error throwing

* 👕 fix linter issues

* 🎨 rename param

* 🐛 fix handling normal errors

*  add usage of NodeApiError

* 🎨 fix throw new error instead of constructor

* 🎨 remove unnecessary code/comments

* 🎨 adjusted spacing + updated status messages

* 🎨 fix tab indentation

*  Replace current errors with custom errors (#1576)

*  Introduce NodeApiError in catch blocks

*  Introduce NodeOperationError in nodes

*  Add missing errors and remove incompatible

*  Fix NodeOperationError in incompatible nodes

* 🔧 Adjust error handling in missed nodes

PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes

* 🔨 Adjust Strava Trigger node error handling

* 🔨 Adjust AWS nodes error handling

* 🔨 Remove duplicate instantiation of NodeApiError

* 🐛 fix strava trigger node error handling

* Add XML parsing to NodeApiError constructor (#1633)

* 🐛 Remove type annotation from catch variable

*  Add XML parsing to NodeApiError

*  Simplify error handling in Rekognition node

*  Pass in XML flag in generic functions

* 🔥 Remove try/catch wrappers at call sites

* 🔨 Refactor setting description from XML

* 🔨 Refactor let to const in resource loaders

*  Find property in parsed XML

*  Change let to const

* 🔥 Remove unneeded try/catch block

* 👕 Fix linting issues

* 🐛 Fix errors from merge conflict resolution

*  Add custom errors to latest contributions

* 👕 Fix linting issues

*  Refactor MongoDB helpers for custom errors

* 🐛 Correct custom error type

*  Apply feedback to A nodes

*  Apply feedback to missed A node

*  Apply feedback to B-D nodes

*  Apply feedback to E-F nodes

*  Apply feedback to G nodes

*  Apply feedback to H-L nodes

*  Apply feedback to M nodes

*  Apply feedback to P nodes

*  Apply feedback to R nodes

*  Apply feedback to S nodes

*  Apply feedback to T nodes

*  Apply feedback to V-Z nodes

*  Add HTTP code to iterable node error

* 🔨 Standardize e as error

* 🔨 Standardize err as error

*  Fix error handling for non-standard nodes

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00
Jon Bake
54f949a972 🐛 Fixes #1364 - Incorrect mouse selection when zoomed in or out (#1498)
Prior to this change, the mouse selection box had a fixed position on the page. Nodes have absolute
position within NodeView. This inconsistency in positioning caused issues when calculating
if a node was positioned within the mouse selection. This solution makes both nodes
and mouse selection have consistent positioning, along with correctly calculating the
mouse click position within NodeView when making a selection.
2021-02-28 18:08:14 +01:00
Jan Oberhauser
deaa015e61 Do only send manual executions to starting session & cleanup 2021-02-13 20:40:27 +01:00
Omar Ajoue
e53efdd337 Separate webhooks from core (#1408)
* Unify execution ID across executions

* Fix indentation and improved comments

* WIP: saving data after each node execution

* Added on/off to save data after each step, saving initial data and retries working

* Fixing lint issues

* Fixing more lint issues

*  Add bull to execute workflows

* 👕 Fix lint issue

*  Add graceful shutdown to worker

*  Add loading staticData to worker

* 👕 Fix lint issue

*  Fix import

* Changed tables metadata to add nullable to stoppedAt

* Reload database on migration run

* Fixed reloading database schema for sqlite by reconnecting and fixing postgres migration

* Added checks to Redis and exiting process if connection is unavailable

* Fixing error with new installations

* Fix issue with data not being sent back to browser on manual executions with defined destination

* Merging bull and unify execution id branch fixes

* Main process will now get execution success from database instead of redis

* Omit execution duration if execution did not stop

* Fix issue with execution list displaying inconsistant information information while a workflow is running

* Remove unused hooks to clarify for developers that these wont run in queue mode

* Added active pooling to help recover from Redis crashes

* Lint issues

* Changing default polling interval to 60 seconds

* Removed unnecessary attributes from bull job

* Added webhooks service and setting to disable webhooks from main process

* Fixed executions list when running with queues. Now we get the list of actively running workflows from bull.

* Add option to disable deregistration of webhooks on shutdown

* Rename WEBHOOK_TUNNEL_URL to WEBHOOK_URL keeping backwards compat.

* Added auto refresh to executions list

* Improvements to workflow stop process when running with queues

* Refactor queue system to use a singleton and avoid code duplication

* Improve comments and remove unnecessary commits

* Remove console.log from vue file

* Blocking webhook process to run without queues

* Handling execution stop graciously when possible

* Removing initialization of all workflows from webhook process

* Refactoring code to remove code duplication for job stop

* Improved execution list to be more fluid and less intrusive

* Fixing workflow name for current executions when auto updating

*  Right align autorefresh checkbox

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-02-09 23:32:40 +01:00
Jan Oberhauser
5398a06ff2 Add variable $mode 2021-01-29 09:31:40 +01:00
Ahsan Virani
4d446229c3 Introduce FE external hooks (#1332)
*  Introduce FE external hooks

*  update hooks

*  add data from frontend settings to hooks

* re-organize and update

* cleanup

* 👌

*  cleanup workflowSave mixin, add events

* avoid alert on new workflow save as

*  update workflow active events

* rename externalhooks method

*  Rename frontend hooks

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-01-19 23:48:30 +01:00
Jan Oberhauser
75cca869b4 Fix issue that source node was also selected after duplicate 2020-12-24 08:37:13 +01:00
Tristian Flanagan
137c334389 Add horizontal scroll (#1172) 2020-11-18 23:29:12 +01:00
Jan Oberhauser
9465653fab Improve editor-UI dirty checking 2020-11-04 13:04:40 +01:00
Jan
72ac20b070 Improvements on #911 to display unsaved changes. Now works with back button. (#1098)
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2020-10-25 12:47:49 +01:00
Jan
dc93694a1a Merge branch 'master' into save-changes-warning 2020-10-25 11:47:47 +01:00
Jan Oberhauser
044c986f30 👕 Fix lint issue 2020-10-23 19:13:25 +02:00
Jan Oberhauser
d90a5e5dc6 Improve wheel-scrolling in Firefox 2020-10-23 18:43:30 +02:00
Jan Oberhauser
c40601eecb Fix issues with support for touch-devices 2020-10-23 18:16:00 +02:00
Jan Oberhauser
4df74771e3 Improve support for touch-devices #1070 2020-10-23 13:51:39 +02:00
Omar Ajoue
37f787d7b2 Load node properties on demand (#1089)
*  Changed rest api endpoint to omit node properties by default.
 Created another endpoint to return all node information based on a list of names

* refactor: changed endpoint to POST instead of GET

* Changed properties to be optional for node description

* Removed eager loading for node properties.

All nodes will have their properties fetched when used in a workflow.
Works when opening an already saved workflow, creating a new one from
scratch or pasting JSON / URLs.

* Removing unnecessary dependency
2020-10-22 17:24:35 +02:00
Jan Oberhauser
c8d009bced Add expression support to credentials 2020-09-12 12:16:07 +02:00
Rupenieks
33582655f2 Revert " Deconstructed store mutation data parameters for better readability"
This reverts commit 17ab16d248.
2020-09-09 14:28:13 +02:00
Rupenieks
17ab16d248 Deconstructed store mutation data parameters for better readability 2020-09-09 14:05:11 +02:00
Rupenieks
3e1ada7c1a 🚧 Added Vuex dirty state flag as central source of truth for if there are unsaved changes 2020-09-01 16:06:08 +02:00
rupenieks
66b76d16ee Merged contributor work 2020-08-31 13:08:27 +02:00
Jan Oberhauser
317949d765 Remove left behind debug code 2020-08-26 21:30:24 +02:00
Jan Oberhauser
b78145f2ec Fix issues with Dynamic title 2020-08-25 20:39:14 +02:00
Rupenieks
44f7b7a9c2 Dynamic title based on workflow execution (#865)
*  Added title changes based on workflow execution

*  Title changes on workflow open, reset on workflow delete, fixed not showing when page refreshed

*  Title icons
2020-08-25 20:37:24 +02:00
Erin
5f32341a9e Remove logs 2020-07-20 11:52:24 -04:00
Erin
ad1228e0ea Everything works except refresh 2020-07-09 16:54:50 -04:00
Jan Oberhauser
9cae58c787 🐛 Fix issue that nodes can not be opened in readOnly-Mode 2020-06-08 00:34:15 +02:00
ricardo
af3d799e5c Oauth1 support and Twitter node 2020-06-01 20:42:44 -04:00
Jan Oberhauser
f1f09d4a03 🔀 Merge branch 'master' into oauth-support 2020-05-24 20:37:59 +02:00
Jan Oberhauser
5718330e29 🐛 Fix issues in read-only mode #39 2020-05-24 14:22:15 +02:00
Jan Oberhauser
147c50485c 🔀 Merge branch 'master' into oauth-support 2020-05-12 01:56:27 +02:00
Jan Oberhauser
1ed72af255 🐛 Fix issue with push messages that get received to fast 2020-05-01 10:45:28 +02:00
Jan Oberhauser
9dd9e0d8ba 🔀 Merge branch 'master' into oauth-support 2020-04-04 17:34:10 +02:00
Jan Oberhauser
70286b469e Make workflow metadata available in expresions and
node-functions
2020-02-15 17:07:01 -08:00
Jan Oberhauser
1777f171bd Ignore node-parameter-issues on disabled nodes 2020-02-09 23:37:08 -08:00
Jan Oberhauser
7ee03cf132 Ignore node-credential-issues on disabled nodes 2020-02-09 23:24:12 -08:00
Jan Oberhauser
70e972ff7d Revert "🔀 Merge branch 'oauth-support' of https://github.com/tildabio/n8n"
This reverts commit 0c5972bb98, reversing
changes made to 3de03b5097.
2020-01-10 14:26:06 -06:00
Jan Oberhauser
dfc3cb962c 👕 Fix lint issue 2020-01-07 23:23:43 -06:00
Jan Oberhauser
740cb8a6fc Some small changes to basic OAuth support 2020-01-07 18:29:11 -06:00
Jan Oberhauser
0c5972bb98 🔀 Merge branch 'oauth-support' of https://github.com/tildabio/n8n 2020-01-06 18:01:45 -06:00
Jan Oberhauser
6b2dc25059 🐛 Fix errors with unknown nodeTypes 2020-01-04 22:51:54 -06:00
Ram Yalamanchili
cb73853680 Add UI logic to support OAuth authentication flow
Add support in credentialsList to kickoff an OAuth2 authorization
flow. This enables users to authenticate and allow n8n to store
the resulting keys in the backend.
2020-01-01 22:55:16 -08:00
Jan Oberhauser
0ba712cd92 👕 Fix lint issue 2019-12-29 15:13:15 -06:00
Jan Oberhauser
49e2285573 ⬆️ Update packages to latest version on n8n-editor-ui 2019-12-29 15:02:21 -06:00
Jan Oberhauser
1ed5a4589d Improve handling of incorrect return data of Function Nodes 2019-12-23 14:54:27 -06:00
Jan Oberhauser
403c52ddf8 🐛 Add missing file 2019-12-18 14:17:31 -06:00