Commit Graph

9 Commits

Author SHA1 Message Date
कारतोफ्फेलस्क्रिप्ट™
6a8c9b7ccc refactor: Improve typings for webhook methods (no-changelog) (#5713) 2023-03-17 12:25:31 +01:00
कारतोफ्फेलस्क्रिप्ट™
3c57062571 refactor: Fix some typos (no-changelog) (#5616) 2023-03-03 18:49:19 +01:00
Iván Ovejero
b03e358a12 refactor: Integrate consistent-type-imports in nodes-base (no-changelog) (#5267)
* 👕 Enable `consistent-type-imports` for nodes-base

* 👕 Apply to nodes-base

* ⏪ Undo unrelated changes

* 🚚 Move to `.eslintrc.js` in nodes-base

* ⏪ Revert "Enable `consistent-type-imports` for nodes-base"

This reverts commit 529ad72b051478fa1633aaf84b2864f2fdc7613c.

* 👕 Fix severity
2023-01-27 12:22:44 +01:00
OlegIvaniv
79fe57dad8 feat(editor): Node creator actions (#4696)
* WIP: Node Actions List UI

* WIP: Recommended Actions and preseting of fields

* WIP: Resource category

* 🎨 Moved actions categorisation to the server

* 🏷️ Add missing INodeAction type

* ✨ Improve SSR categorisation, fix adding of mixed actions

* ♻️ Refactor CategorizedItems to composition api, style fixes

* WIP: Adding multiple nodes

* ♻️ Refactor rest of the NodeCreator component to composition API, conver globalLinkActions to composable

* ✨ Allow actions dragging, fix search and refactor passing of actions to categorized items

* 💄 Fix node actions title

* Migrate to the pinia store, add posthog feature and various fixes

* 🐛 Fix filtering of trigger actions when not merged

* fix: N8N-5439 — Do not use simple node item when at NodeHelperPanel root

* 🐛 Design review fixes

* 🐛 Fix disabling of merged actions

* Fix trigger root filtering

* ✨ Allow for custom node actions parser, introduce hubspot parser

* 🐛 Fix initial node params validation, fix position of second added node

* 🐛 Introduce operations category, removed canvas node names overrride, fix API actions display and prevent dragging of action nodes

* ✨ Prevent NDV auto-open feature flag

* 🐛 Inject recommened action for trigger nodes without actions

* Refactored NodeCreatorNode to Storybook, change filtering of merged nodes for the trigger helper panel, minor fixes

* Improve rendering of app nodes and animation

* Cleanup, any only enable accordion transition on triggerhelperpanel

* Hide node creator scrollbars in Firefox

* Minor styles fixes

* Do not copy the array in rendering method

* Removed unused props

* Fix memory leak

* Fix categorisation of regular nodes with a single resource

* Implement telemetry calls for node actions

* Move categorization to FE

* Fix client side actions categorisation

* Skip custom action show

* Only load tooltip for NodeIcon if necessary

* Fix lodash startCase import

* Remove lodash.startcase

* Cleanup

* Fix node creator autofocus on "tab"

* Prevent posthog getFeatureFlag from crashing

* Debugging preview env search issues

* Remove logs

* Make sure the pre-filled params are update not overwritten

* Get rid of transition in itemiterator

* WIP: Rough version of NodeActions keyboard navigation, replace nodeCreator composable with Pinia store module

* Rewrite to add support for ActionItem to ItemIterator and make CategorizedItems accept items props

* Fix category item counter & cleanup

* Add APIHint to actions search no-result, clean up NodeCreatorNode

* Improve node actions no results message

* Remove logging, fix filtering of recommended placeholder category

* Remove unused NodeActions component and node merging feature falg

* Do not show regular nodes without actions

* Make sure to add manual trigger when adding http node via actions hint

* Fixed api hint footer line height

* Prevent pointer-events od NodeIcon img and remove "this" from template

* Address PR points

* Fix e2e specs

* Make sure canvas ia loaded

* Make sure canvas ia loaded before opening nodeCreator in e2e spec

* Fix flaky workflows tags e2e getter

* Imrpove node creator click outside UX, add manual node to regular nodes added from trigger panel

* Add manual trigger node if dragging regular from trigger panel
2022-12-09 10:56:36 +01:00
Michael Kret
61e26804ba refactor(core): Remove linting exceptions in nodes-base (#4794)
* ⚡ enabled array-type

* ⚡ await-thenable on

* ⚡ ban-types on

* ⚡ default-param-last on

* ⚡ dot-notation on

* ⚡ member-delimiter-style on

* ⚡ no-duplicate-imports on

* ⚡ no-empty-interface on

* ⚡ no-floating-promises on

* ⚡ no-for-in-array on

* ⚡ no-invalid-void-type on

* ⚡ no-loop-func on

* ⚡ no-shadow on

* ⚡ ban-ts-comment re enabled

* ⚡ @typescript-eslint/lines-between-class-members on

* address my own comment

* @typescript-eslint/return-await on

* @typescript-eslint/promise-function-async on

* @typescript-eslint/no-unnecessary-boolean-literal-compare on

* @typescript-eslint/no-unnecessary-type-assertion on

* prefer-const on

* @typescript-eslint/prefer-optional-chain on

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-12-02 21:54:28 +01:00
Michael Kret
479644a499 refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ (#4523)
* ⚡ rule and fixes

* ⚡ clean up
2022-11-08 15:28:21 +01:00
Iván Ovejero
d2b97c0713 refactor(core): apply lint rule node-class-description-non-core-color-present (#4426)
* 👕 Enable rule `node-class-description-non-core-color-present`

* 👕 Apply rule to remove deprecated `color`

* ✏️ Fix unrelated typos

* ✏️ Fix another unrelated typo

Co-authored-by: Michael Kret <michael.k@radency.com>
2022-10-25 09:06:54 +02:00
Iván Ovejero
26b07e28f0 refactor(nodes-base): Apply lint rule node-param-display-name-not-first-position (#4073)
* 👕 Enable rule

* 👕 Apply rule
2022-09-12 09:25:39 +02:00
brianinoa
74cedd94a8 feat(SendInBlue Node): Add SendInBlue Regular + Trigger Node (#3746)
* add sendinblue svg icon

* Add code and required files for new sendinblue node

* Add node to package.json

* Update credentials to display API Key instead of Access Token

* Use new svg found in brandfetch

* ⚡ Improvements

* ♻️ Moved descriptions for email to it's own file

* ⚡ Added support for contact get

* ⚡ moved email descriptions to it's own file

* ⚡ Add logic to conditionally remove/format sms,email

* ⚡ Improvements

* ⚡ Refactor Sender descriptions to it's own file

* ⚡ Fix urls

* ⚡ Improvements attempt

* ⚡ Refactor remove inline descriptions

* ⚡ Minor improvement

* 🎨 Learn a nice way to send options as key-value

* ⚡ Improvements

* ♻️ Fix Create Operation structure

* ♻️ Refactor create functionality for attribute

♻️ Introduce override for createAttribute selectedCategory

♻️ Add delete functionality

* 🔥 Remove preSend from delete

* ⚡ Implement override for body types

* ⚡ Cleanup node file

* ⚡ Update response for contact update
⚡ Update request url for contact delete

* ⚡ Add presend check for optional properties that are empty
⚡ Add Model file and TransactionalEmail interface

* ⚡ formatting

* ♻️ Remove requestOperations from Node Description level

* ♻️ Cleanup routing for Get All
♻️ Make Identifier required

* ⚡ Formatting

* ♻️ Add Options Collection

* ♻️ Add Filters area

* ♻️ Formatting

* ♻️ Handle empty return

* ♻️ Remove unused code

* ♻️ Fix pagination
♻️ Fix empty return for delete

* ⚡ Add pagination

* ⚡ Fix Modified Since

* ♻️ Reorder send operation ui

* ⚡ Remove no longer needed presend
⚡ Add send html template operation

* ♻️ Make Contact Attribute name and type required

* ♻️ Rename Attribute to Contact Attribute

* ♻️ Rename Identifier to Contact Identifier

* ♻️ Remove SMS from root level because it can exist in Contact Attributes

* ♻️ Fix Array type using 'Array<T>'
♻️ Fix double quotes should be single quotes

* 👕 Lint Fix

* ⚡ Add email attachment functionality
⚡ Add attachment data validation

* ⚡ Add dynamic loading of Email Template IDs

* ♻️ Cleanup validation method

* ⚡ Introduce workaround and use binary data for attachments

* feat: Migrated to npm release of riot-tmpl fork.

* 👕 Lint fix rules

* 👕 Lint fix rules

* fix: Updated imports to use @n8n_io/riot-tmpl

* fix: Fixed Logger.ts types.

* ⚡ Fix mixmatch of filename and package.json credentials list

* ⚡ fix mixmatch in nodes list

* feat(core): Give access to getBinaryDataBuffer in preSend method

* ⚡ clean up mixmatches in node naming

* ♻️ Refactor code to use newly exposed getBinaryDataBuffer method

* ⚡ Improvements

* 🔥 Remove unnecessary lines

* 👕 Fix linting issues

* ⚡ Fix issues with up to date APIs and improve readability

* ⚡ update naming of files

* ♻️ Move sendHtml boolean above subject
♻️ Update naming from Parameters to Fields

* ♻️ Move sendHtml boolean above subject
♻️ Update naming from Parameters to Fields

* ♻️ Add attribute name url encoding
♻️ Change limit's default to 50

* ⚡ Fix default for templateId

* ⚡ Fix display name for attribute list

* ♻️ Add clarity to attribute value display name

* ♻️ Add tags and attachments for emails

* ♻️ Add use of item's binary data fileName

* 👕 Fix action lint rule

* 👕 Remove deprecated lint rule

* ⬆️ Update eslint-plugin-n8n-nodes-base

* 👕 Fix lint rule for file name

* ⚡ Fix update attribute

* ♻️ Add upsert capabilites

* 🔥 Remove create or update operation

* ♻️ Add sendInBlueWebhookApi namespace

* ♻️ Add Webhook API functionality

* ⚡ Add SendInBlue Trigger

* ⚡ Return correct webhookId data

* ⚡ Add placeholder for receiving data

* 👕 Fixing existing linting issues

* 🚨 Enable namespacing in tslint file

* 👕 Fix linting issues

* ⚡ Rename exported WebhookApi

* 🔥 Remove unused Model.ts file

* ♻️ Update node to use SendInBlue namespace

* ⚡ Revert back to allowing upsert functionality

* ♻️ Fix options to better describe events

* Remove update flag for create operation

* ♻️ Fix discrepancies for contact resource

* remove no-namespace lint rule

* 👕 Fix linting issues

* ♻️ Add sendInBlueWebhookApi namespace

* ♻️ Add Webhook API functionality

* ⚡ Add SendInBlue Trigger

* ⚡ Return correct webhookId data

* ⚡ Add placeholder for receiving data

* 👕 Fix linting issues

* ⚡ Rename exported WebhookApi

* ♻️ Fix options to better describe events

* Add optionswithuri import that was lost

* ⚡ Fix details from janober's review

* ⚡ Fix order of displayName and name properties

* ⚡ Fix default value and improve loadOptions

* ⚡ Introduce support for comma separated attribute values

* ⚡ Introduce support for comma separated attribute values

* 👕 Fix linting issues

* Update defaults and required props

* ⚡ Fix copy paste issue Upsert was not using correct endpoint

* ⚡ Fix upsert email field display name

* ⚡ Last update, upsert email description

* ⚡ Add PostReceived type limit

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2022-08-03 18:08:51 +02:00