Commit Graph

700 Commits

Author SHA1 Message Date
कारतोफ्फेलस्क्रिप्ट™
a115baa1ac fix(core): CORS middleware should not process the entire handler chain on OPTIONS requests (no-changelog) (#5368)
fix(core): CORS middleware should not process the entire handler chain on OPTIONS requests
2023-02-06 12:43:50 +01:00
OlegIvaniv
6985500a7d fix(core): Fix populating of node custom api call options (#5347)
* feat(core): Fix populating of node custom api call options

* lint fixes

* Adress PR comments

* Add e2e test and only inject custom API options for latest version

* Make sure to injectCustomApiCallOption for the latest version of node

* feat(cli): Move apiCallOption injection to LoadNodesAndCredentials and add e2e tests to check for custom nodes credentials

* Load nodes and credentials fixtures from a single place

* Console warning if credential is invalid during customApiOptions injection
2023-02-03 13:14:59 +01:00
कारतोफ्फेलस्क्रिप्ट™
4dab2fec49 fix(core): Add missing schema keys for LDAP (no-changelog) (#5348) 2023-02-03 12:50:08 +01:00
कारतोफ्फेलस्क्रिप्ट™
56326cb317 fix(core): Use custom cache control only on editor-ui assets (no-changelog) (#5346) 2023-02-03 11:27:24 +01:00
OlegIvaniv
616074158c fix(core): Revert custom API option injecting (#5345)
Revert "feat(core): Fix populating of node custom api call options (#5303)"

This reverts commit e58bc41d24.
2023-02-02 20:03:45 +01:00
Omar Ajoue
b5154d9be5 fix: Prevent unnecessarily touching updatedAt when n8n starts (#5340)
* Include MariaDB in exception list

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-02-02 17:01:45 +01:00
freya
6ca49f9d54 fix(core): Prevent shared user details being saved alongside execution data (#5334)
* 🔨 - Remove `shared` key from execution save data

* 👕 - Using import type where needed

* remove console.log

* 🔨 - Create new clean workflowData instead of removing shared

If IWorkflowBase changes in future, TS will error out here ensuring it's kept up to date

* 🔨 - use lodash.pick for less verbosity

* 🔨 - fix lodash imports
2023-02-02 15:27:00 +00:00
कारतोफ्फेलस्क्रिप्ट™
93a2dac063 fix(core): Fix env file config loading (no-changelog) (#5339)
* fix(core): Do not trim config values read from files (no-changelog)

* do not use config.load. it does not work
2023-02-02 15:34:29 +01:00
OlegIvaniv
e58bc41d24 feat(core): Fix populating of node custom api call options (#5303)
* feat(core): Fix populating of node custom api call options

* lint fixes

* Adress PR comments

* Add e2e test and only inject custom API options for latest version

* Make sure to injectCustomApiCallOption for the latest version of node
2023-02-02 14:53:08 +01:00
कारतोफ्फेलस्क्रिप्ट™
6cba652ff9 fix(core): Load config values from files using _FILE env variables (no-changelog) (#5335)
This broke in https://github.com/n8n-io/n8n/pull/5283/
2023-02-02 14:01:55 +01:00
कारतोफ्फेलस्क्रिप्ट™
ee210e8507 feat(core): Set custom Cache-Control headers for static assets (#5322) 2023-02-02 12:15:46 +01:00
कारतोफ्फेलस्क्रिप्ट™
8f5f1c3aa5 fix(Mailchimp Trigger Node): Fix webhook recreation (#5328) 2023-02-02 01:00:24 +01:00
कारतोफ्फेलस्क्रिप्ट™
0de6dc92d7 fix(core): Revert back to console logging in config (no-changelog) (#5319)
broke in https://github.com/n8n-io/n8n/pull/5283
2023-02-01 11:15:00 +01:00
Omar Ajoue
b61453d8e6 fix(core): Allow listing users when logged in (no-changelog) (#5308) 2023-01-31 14:18:23 +01:00
Omar Ajoue
c7e9a4375f refactor: Reduce payload size when fetching workflows to prevent memory issues (#5293) 2023-01-31 11:09:33 +01:00
कारतोफ्फेलस्क्रिप्ट™
5cb7e5007d feat(core): Export OpenAPI spec for external tools (#5294)
The generated spec is available at /api/v1/openapi.yml
2023-01-30 17:38:31 +01:00
कारतोफ्फेलस्क्रिप्ट™
72249e0de8 refactor(core): Load and validate all config at startup (no-changelog) (#5283) 2023-01-30 14:42:30 +01:00
Iván Ovejero
2ca959b383 refactor: Integrate consistent-type-imports in BE packages (no-changelog) (#5270) 2023-01-27 14:56:56 +01:00
कारतोफ्फेलस्क्रिप्ट™
845f0f9d20 refactor(core): Switch over all user-management routes to use decorators (#5115) 2023-01-27 11:19:47 +01:00
Iván Ovejero
0a7ea89633 fix: Fix formatting/linting for CI (no-changelog) (#5264)
* ⬆️ Upgrade Prettier

* 📦 Update `pnpm-lock.yaml`

* 🎨 Format all packages

* 🔧 Specify `prettierPath`
2023-01-27 10:18:15 +01:00
Alex Grozav
99e35f1e94 feat(editor): Update design-system and editor dependencies (no-changelog) (#5188) 2023-01-27 02:09:30 +01:00
कारतोफ्फेलस्क्रिप्ट™
68e4083bbd fix(core): Validate numeric ids in the public API (#5251)
This was incorrectly changed in https://github.com/n8n-io/n8n/pull/5041
2023-01-26 11:46:00 +01:00
कारतोफ्फेलस्क्रिप्ट™
c8a146ba31 ci: Fix CI timeout issues (no-changelog) (#5250) 2023-01-26 11:44:50 +01:00
कारतोफ्फेलस्क्रिप्ट™
21579a8a2a fix(core): Handle missing binary metadata in download urls (#5242) 2023-01-25 10:19:19 +01:00
Ricardo Espinoza
0c70a40317 feat(core): Add LDAP support (#3835) 2023-01-25 02:18:39 +01:00
कारतोफ्फेलस्क्रिप्ट™
259296c5c9 fix(core): Upsert credentials and workflows in the import:* commands (#5231) 2023-01-24 19:05:23 +01:00
कारतोफ्फेलस्क्रिप्ट™
a86c9a628b refactor(core): Add support for implicit schema in postgres migrations (#5233) 2023-01-24 10:55:20 +01:00
Iván Ovejero
fcbf4fd587 fix(core): Make pindata with webhook responding on last node manual-only (#5223)
 Add manual check
2023-01-23 12:22:05 +01:00
Michael Auerswald
4f89fb4d4d fix(core): Fix onWorkflowPostExecute not being called (#5224)
fix onWorkflowPostExecute
2023-01-23 11:53:00 +01:00
Omar Ajoue
c5245dd387 fix: Add schema to postgres migrations (hotfix) (#5218)
* fix: Add schema to postgres migrations
2023-01-23 10:16:20 +01:00
agobrech
6e391755e4 fix(core): Fix url in error handelling for the error Trigger (#5201)
* Add workflow id to url in error message

* fix mock message for manual execution

* Fix url missing 's'
2023-01-19 17:56:31 +01:00
Michael Auerswald
9b032d68bc feat(core): Add Prometheus metrics for n8n events and api invocations (experimental) (#5177)
* create prometheus metrics from events

* feat(core): Add more Prometheus metrics (experimental) (#5187)

* refactor(core): Add Prometheus labels to relevant metrics

* feat(core): Add more Prometheus metrics (experimental)

* add 'v' prefix to value of version label

Co-authored-by: Cornelius Suermann <cornelius@n8n.io>
2023-01-19 12:11:31 +01:00
Cornelius Suermann
e36112a6d4 fix(core): Fix migration (no-changelog) (#5186)
* fix(core): Fix migration (no-changelog)

* revert previous fix and apply correct one
2023-01-18 15:42:09 +01:00
Iván Ovejero
c0268f572f fix(core): Restore community nodes installation (#5180)
🐛 Fix check for community nodes not installing
2023-01-17 16:04:58 +01:00
कारतोफ्फेलस्क्रिप्ट™
97969fc815 fix: Upgrade jsonwebtoken to address CVE-2022-23540 (#5116) 2023-01-13 18:24:59 +01:00
कारतोफ्फेलस्क्रिप्ट™
0a5ab560b1 refactor: Upgrade typeorm to 0.3.x (#5151) 2023-01-13 18:12:22 +01:00
Michael Auerswald
e845eb33f9 fix(core): Remove threads pkg, rewrite log writer worker (#5134) 2023-01-13 15:39:25 +01:00
कारतोफ्फेलस्क्रिप्ट™
a9fb393e1a fix: DB revert command shouldn't run full migrations before each revert (#5131) 2023-01-11 18:29:31 +01:00
कारतोफ्फेलस्क्रिप्ट™
62cce2e518 fix: Run every DB migration inside a transaction (#5129)
* always each DB migrations in a transaction

* `VACUUM` isn't allowed inside transactions.

* `PRAGMA foreign_keys` are automatically toggled before and after every down migration
2023-01-11 18:29:05 +01:00
कारतोफ्फेलस्क्रिप्ट™
a573db2ef7 fix: Report app startup and DB migration errors to Sentry (#5127) 2023-01-11 18:28:35 +01:00
Michael Auerswald
62d06b1e6e fix(core): Fixes event msg confirmations if no subscribers present (#5118)
* adds ExecutionEvents view modal to ExecutionList

* fix time rendering and remove wf column

* checks for unfinished executions and fails them

* prevent re-setting stoppedAt for execution

* removing UI changes but keeping eventbus fixes

* remove comment
2023-01-11 14:09:09 +01:00
कारतोफ्फेलस्क्रिप्ट™
0e955760a1 refactor: On workflow deletion, cascade delete all entities associated with it (#5102) 2023-01-10 09:23:44 +01:00
Omar Ajoue
a43e3e4112 fix: Do not attempt to save statistics data for unsaved workflows (#5106)
* fix: Do not attempt to save data for unsaved workflows
2023-01-09 12:49:27 +01:00
कारतोफ्फेलस्क्रिप्ट™
6d0f2bff7f fix: Remove anonymous ID from tracking calls (#5099) 2023-01-06 15:35:30 +01:00
कारतोफ्फेलस्क्रिप्ट™
c4df2049a8 fix: Stop OOM crashes in Execution Data pruning (#5095)
* fix: Stop OOM crashed in Execution Data pruning

Currently while pruning execution data, we are loading all the data in memory. For instances where there are thousands of executions, this causes the container to run out of memory.
Since ids is all we need, we should only query for ids.

* query for Executions only when ids are actually needed for pruning binary data

in default mode the binary data is in the database, and will get pruned along with the executions.
2023-01-06 11:42:58 +01:00
कारतोफ्फेलस्क्रिप्ट™
d77523bd31 fix: Pass in the correct server reference to external hooks (no-changelog) (#5094)
* fix: Pass in the correct server reference to external hooks (no-changelog)

* use the correct reference
2023-01-05 16:56:27 +01:00
Alex Grozav
2327563c44 feat: Add user management invite links without SMTP set up (#5084)
* feat: update n8n-users-list to no longer use preset list of actions

* feat: prepared users settings for invite links feature

* refactor: Return invite link URLs when inviting users (#5079)

* refactor: Return invite link URLs when inviting users

* test: Refactor and add tests to mailer

* feat: Add FE inviteAcceptUrl integration (#5085)

* feat: update n8n-users-list to no longer use preset list of actions

* feat: prepared users settings for invite links feature

* feat: add integration with new inviteAcceptUrl changes

* feat: Add inviteAcceptUrl to user list for pending users

Co-authored-by: Alex Grozav <alex@grozav.com>

* fix conflicts

* fix lint issue

* test: Make sure inviteAcceptUrl is defined

* feat: update smtp setup suggestion

* feat: add invite link summary when inviting multiple users

* refactor: Add telemetry flag for when email is sent

* fix: add email_sent correctly to telemetry event

* feat: move SMTP info-tip to invite modal

Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-01-05 17:10:08 +02:00
Omar Ajoue
11a46a4cbc fix: Remove annonymous ID (no-changelog) (#5093) 2023-01-05 14:59:21 +01:00
Jan Oberhauser
93da026c0d fix(core): Fix OAuth credential creation via API (#5064)
* fix(core): Fix OAuth credential creation via API

* Fix tests
2023-01-05 07:06:37 -06:00
Iván Ovejero
d548161632 feat(core): Security audit (#5034)
*  Implement security audit

*  Use logger

* 🧪 Fix test

*  Switch logger with stdout

* 🎨 Set new logo

*  Fill out Public API schema

* ✏️ Fix typo

*  Break dependency cycle

*  Add security settings values

* 🧪 Test security settings

*  Add publicly accessible instance warning

*  Add metric to CLI command

* ✏️ Fix typo

* 🔥 Remove unneeded path alias

* 📘 Add type import

* 🔥 Remove inferrable output type

*  Set description at correct level

*  Rename constant for consistency

*  Sort URLs

*  Rename local var

*  Shorten name

* ✏️ Improve phrasing

*  Improve naming

*  Fix casing

* ✏️ Add docline

* ✏️ Relocate comment

*  Add singular/plurals

* 🔥 Remove unneeded await

* ✏️ Improve test description

*  Optimize with sets

*  Adjust post master merge

* ✏️ Improve naming

*  Adjust in spy

* 🧪 Fix outdated instance test

* 🧪 Make diagnostics check consistent

*  Refactor `getAllExistingCreds`

*  Create helper `getNodeTypes`

* 🐛 Fix `InternalHooksManager` call

* 🚚 Rename `execution` to `nodes` risk

*  Add options to CLI command

*  Make days configurable

* :revert: Undo changes to `BaseCommand`

*  Improve CLI command UX

*  Change no-report return value

Empty array to trigger empty state on FE.

*  Add empty check to `reportInstanceRisk`

* 🧪 Extend Jest `expect`

* 📘 Augment `jest.Matchers`

* 🧪 Set extend as setup file

* 🔧 Override lint rule for `.d.ts`

*  Use new matcher

*  Update check

* 📘 Improve typings

*  Adjust instance risk check

* ✏️ Rename `execution` → `nodes` in Public API schema

* ✏️ Add clarifying comment

* ✏️ Fix typo

*  Validate categories in CLI command

* ✏️ Improve naming

* ✏️ Make audit reference consistent

* 📘 Fix typing

*  Use `finally` in CLI command
2023-01-05 13:28:40 +01:00