Commit Graph

357 Commits

Author SHA1 Message Date
Iván Ovejero
1d46983b24 refactor: Unify severity and level for all application errors for Sentry (no-changelog) (#7956)
## Summary
Unify `severity` and `level` for all backend application errors for
Sentry

Follow-up to:
https://github.com/n8n-io/n8n/pull/7914#issuecomment-1840433542

...

#### How to test the change:
1. ...


## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers

...


## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
2023-12-07 16:57:02 +01:00
Iván Ovejero
9b877a9427 fix(Google Sheets Node): Prevent erroring on zero sheet search results (#7957)
## Summary
https://n8nio.sentry.io/issues/4695063783

...

#### How to test the change:
1. ...


## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers

...


## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).
2023-12-07 16:12:07 +01:00
Iván Ovejero
e77fd5d286 refactor: Switch plain errors in nodes-base to ApplicationError (no-changelog) (#7914)
Ensure all errors in `nodes-base` are `ApplicationError` or children of
it and contain no variables in the message, to continue normalizing all
the backend errors we report to Sentry. Also, skip reporting to Sentry
errors from user input and from external APIs. In future we should
refine `ApplicationError` to more specific errors.

Follow-up to: [#7877](https://github.com/n8n-io/n8n/pull/7877)

- [x] Test workflows:
https://github.com/n8n-io/n8n/actions/runs/7084627970
- [x] e2e: https://github.com/n8n-io/n8n/actions/runs/7084936861

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-12-05 11:17:08 +01:00
Michael Kret
ade3acf800 fix(Google Sheets Node): Missing version fo RMC (no-changelog) (#7886)
Github issue / Community forum post (link here to close automatically):
2023-11-30 17:24:43 +02:00
Jon
5207a2fe52 fix(Google Sheets Node): Fix issue with paired items not being set correctly (#7862)
https://community.n8n.io/t/error-unknown-top-level-item-key-paireditems-item-0/33536/

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-29 14:12:50 +00:00
Michael Kret
c72229fbe2 fix(core): Rename ’Marketing & Content' category to 'Marketing' (no-changelog) (#7823)
Github issue / Community forum post (link here to close automatically):
2023-11-29 13:37:46 +02:00
Jon
38f24a6184 fix(Google Calendar Trigger Node): Fix issue preventing birthday and holiday calendars from working (#7832)
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/issue-with-some-google-calendars/33411

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-11-28 09:11:05 +00:00
Michael Kret
d5488725a8 fix(Google Sheets Node): Read operation execute for each item (#7800)
Github issue / Community forum post (link here to close automatically):
2023-11-28 11:02:11 +02:00
Csaba Tuncsik
e128b23a2b build: Upgrade to Vite 5 (#7784) 2023-11-23 11:55:02 +01:00
Iván Ovejero
5d4a52d3b7 fix(Google Sheets Node): Check for null before destructuring (#7729)
https://n8nio.sentry.io/issues/4613453684
2023-11-16 16:50:06 +01:00
Jon
b1f678856b docs(Google Sheets Node): Change Get Many to Get Row(s) (#7677)
Github issue / Community forum post (link here to close automatically):
2023-11-15 10:05:36 +00:00
Michael Kret
88efb99587 fix(Google Sheets Node): Append exceeding grid limits (#7684)
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/error-appending-data-with-google-sheets/28691
2023-11-15 11:33:47 +02:00
Michael Kret
18623c7376 feat(Microsoft Excel 365 Node): Alias update (no-changelog) (#7659)
Github issue / Community forum post (link here to close automatically):
2023-11-09 16:56:59 +02:00
Iván Ovejero
52f655f3d2 refactor(Google Sheets Node): Stop reporting to Sentry sheet not found error (no-changelog) (#7617)
https://n8nio.sentry.io/issues/4264383378
2023-11-06 11:36:22 +01:00
Jackson
ea5cd3140f docs: Fix spelling issue in Gmail trigger node (#7545)
IDK how I noticed this
2023-10-30 11:30:53 +01:00
Iván Ovejero
62c096710f refactor: Run lintfix (no-changelog) (#7537)
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
Iván Ovejero
d885daa6a1 refactor(Google Sheets Node): Prevent reporting to Sentry failure to find spreadsheet (no-changelog) (#7518)
To silence this very frequently reported error:
https://n8nio.sentry.io/issues/3823103947/?project=4503924908883968&query=&referrer=issue-stream&statsPeriod=90d&stream_index=0
2023-10-26 11:33:11 +02:00
कारतोफ्फेलस्क्रिप्ट™
b6de910cbe refactor(core): Abstract away InstanceSettings and encryptionKey into injectable services (no-changelog) (#7471)
This change ensures that things like `encryptionKey` and `instanceId`
are always available directly where they are needed, instead of passing
them around throughout the code.
2023-10-23 13:39:35 +02:00
Michael Kret
ab6a9bbac2 fix(Google Sheets Node): Append or update runs forever when without column headers (#7463)
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-10-19 14:54:13 +03:00
Michael Kret
d8531a53b9 fix(Google Sheets Node): Tweaks (#7357)
Github issue / Community forum post (link here to close automatically):
2023-10-17 18:41:30 +03:00
Jon
9d241a0d6d feat(Google Calendar Trigger Node): Add support for cancelled events (#7436)
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/google-calendar-trigger-deleted-events/10612

This PR adds support for triggering workflows when Google Calendar
events are cancelled.
2023-10-16 14:09:23 +01:00
Michael Kret
e2c3c7aceb fix(core): Missing pairing info (#7326)
Github issue / Community forum post (link here to close automatically):
2023-10-10 18:36:20 +03:00
कारतोफ्फेलस्क्रिप्ट™
732b15a1fa fix(Google Sheets Node): Fix "Maximum call stack size exceeded" error on too many rows (#7384)
Fixes:

1. https://community.n8n.io/t/google-sheets-error-maximum-call-stack-size-exceeded/31006
2. https://community.n8n.io/t/error-maximum-call-stack-size-exceeded-in-google-sheet-read-rows/20307
2023-10-09 16:58:16 +02:00
Elias Meire
3e7a4d3b2c fix(Google Drive Trigger Node): Add Shared Drives support (#7369)
Github issue / Community forum post (link here to close automatically):

https://community.n8n.io/t/google-drive-node-cant-access-google-shared-drives/8760
2023-10-06 19:59:33 +02:00
Michael Kret
97bb703d0a fix(Google BigQuery Node): Location default to jobReference (#7354)
Github issue / Community forum post (link here to close automatically):
2023-10-06 14:16:55 +03:00
Michael Kret
8f9fe6269b feat(core): Add "Sent by n8n" attribution (#7183)
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
2023-10-03 11:18:59 +03:00
Iván Ovejero
75541e91f2 refactor(core)!: Make getBinaryStream async (#7247)
Story: [PAY-846](https://linear.app/n8n/issue/PAY-846) | Related:
https://github.com/n8n-io/n8n/pull/7225

For the S3 backend for external storage of binary data and execution
data, the `getAsStream` method in the binary data manager interface used
by FS and S3 will need to become async. This is a breaking change for
nodes-base.
2023-09-25 16:59:45 +02:00
Giulio Andreini
09a7cf0980 docs(Google Sheets Node): Operations naming update (no-changelog) (#7211)
Github issue / Community forum post (link here to close automatically):
2023-09-20 15:20:56 +02:00
Michael Kret
3a474552b2 feat(Set Node): Overhaul (#6348)
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/pull/6348

---------

Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Marcus <marcus@n8n.io>
2023-09-19 13:16:35 +03:00
Quang-Linh LE
915cfa0f6a fix(Google Cloud Firestore Node): Fix empty string interpreted as number (#7136) 2023-09-12 10:03:33 +01:00
Jon
f07d97fa6e docs: Add email alias to Outlook and GMail (#7127) 2023-09-07 10:42:34 +01:00
कारतोफ्फेलस्क्रिप्ट™
6aa7b93473 refactor(core): Deprecate prepareOutputData (no-changelog) (#7091) 2023-09-05 12:59:02 +02:00
Marcus
00268a019a fix(Google Sheets Node): Fix short sheet name interpreted as range (#6989)
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/6203
2023-08-22 18:05:54 +02:00
Marcus
052dd7cc9d fix(Google Sheets Trigger Node): Support sheet names with non-latin characters (#6970)
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/how-to-get-new-rows-in-google-sheets/25810
2023-08-18 14:38:41 +02:00
Iván Ovejero
f50fc8443e refactor: Reduce usage of IExecuteSingleFunctions (no-changelog) (#6944) 2023-08-16 15:52:41 +02:00
Jon
db21a8db75 fix: Fix issue with key based credentials not being read correctly (#6824) 2023-08-09 12:30:53 +01:00
Iván Ovejero
b82cf5603a ci: Upgrade nodelinter to 1.16.0 (no-changelog) (#6879)
ci: Upgrade nodelinter to 1.16.0
2023-08-09 10:10:08 +02:00
Iván Ovejero
24ce141815 refactor: Clear unused ESLint directives from nodes-base (no-changelog) (#6812)
* refactor: Clear unused ESLint directives from nodes-base (no-changelog)

* removed unused disable directives

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-08-01 15:32:33 +02:00
Iván Ovejero
dec19585bc refactor: Enforce expanded sensitive inputs rules (no-changelog) (#6815)
* refactor: Enforce expanded sensitive inputs rules (no-changelog)

* refactor: Add extra exemption

* fix: Add setting to `sessionToken` fields

* fix: Restore for `hidden` fields

* fix: More edge case exemptions

* fix: One more
2023-08-01 13:08:25 +02:00
Michael Kret
c2511a829c fix(Gmail Trigger Node): Early returns in case of no data (#6727) 2023-07-24 17:29:38 +03:00
Michael Kret
95837d2604 fix(Google BigQuery Node): Error description improvement (#6715) 2023-07-21 13:28:26 +03:00
कारतोफ्फेलस्क्रिप्ट™
cd0e41a6b4 feat(Google Cloud Storage Node): Use streaming for file uploads (#6462)
fix(Google Cloud Storage Node): Use streaming for file uploads
2023-07-19 12:54:31 +02:00
कारतोफ्फेलस्क्रिप्ट™
e57e85edf7 refactor: Delete unnecessary interface re-exports from core, and delete unused code in nodes-base (no-changelog) (#6631) 2023-07-12 11:15:38 +02:00
Iván Ovejero
d6b2ae0255 refactor: Stop using .d.ts files for type-collection files (no-changelog) (#6634)
refactor: Stop using `.d.ts` files for type-collection files
2023-07-10 19:35:34 +02:00
Michael Kret
56721468df fix(Google Drive Node): Fix regex in file RLC (#6607) 2023-07-05 23:15:13 +03:00
Michael Kret
d70a1cb0c8 feat(Google Drive Node): Overhaul (#5941) 2023-06-27 11:51:41 +03:00
Michael Kret
d9ed0b31b5 fix(Google Drive Node): URL parsing (#6527) 2023-06-23 17:12:54 +03:00
Michael Kret
806d134602 fix(Google Sheets Node): Incorrect read of 0 and false (#6525) 2023-06-23 14:24:31 +03:00
Iván Ovejero
beedfb609c feat(editor): SQL editor overhaul (#6282)
* Draft setup
* ⚡ Implemented expression evaluation in Postgres node, minor SQL editor UI improvements, minor refacring
* ⚡ Added initial version of expression preview for SQL editor
* ⚡ Linking npm package for codemirror sql grammar instead of a local file
* ⚡ Moving expression editor wrapper elements to the component
* ⚡ Using expression preview in SQL editor
* Use SQL parser skipping whitespace
* ✨ Added support for custom skipped segments specification
* ✨ Fixing highlight problems with dots and expressions that resolve to zero
* 👕 Fixing linting error
* ✨ Added current item support
* ⚡ Added expression support to more nodes with sql editor
* ✨ Added expression support for other nodes
* ✨ Implemented different SQL dialect support
* 🐛 Fixing hard-coded parameter names for editors
* ✨ Fixing preview for nested queries, updating query when input data changes, adding keyboard shortcut to toggle comments
* ✨ Adding a custom automcomplete notice for different editors
* ⚡ Updating SQL autocomplete notice
* ✅ Added unit tests for SQL editor
* ⚡ Using latest grammar
* 🐛 Fixing code node editor rendering
* 💄 SQL preview dropdown matches editor width. Removing unnecessary css
* ⚡ Addressing PR review feedback
* 👌 Addressing PR review feedback pt2
* 👌 Added path alias for utils in nodes-base package
* 👌 Addressing more PR review feedback
* ✅ Adding tests for `getResolvables` utility function
* ⚡Fixing lodash imports
* 👌 Better focus handling, adding more plugins to the editor, other minor imrovements
* ⚡ Not showing SQL autocomplete suggestions inside expressions
* ⚡ Using npm package for sql grammar
* ⚡ Removing autocomplete notice, adding line highlight on syntax error
* 👌 Addressing code review feedback
---------
Co-authored-by: Milorad Filipovic <milorad@n8n.io>
2023-06-22 16:47:28 +02:00
Chris Wu
1111c915f2 refactor(core): Replace lodash's "soft-deprecated" individual packages with lodash to resolve CVE (no-changelog) (#6450)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-16 16:26:35 +02:00