Tomi Turtiainen
afa43e75f6
test(core): Move unit tests closer to testable components (no-changelog) ( #10287 )
2024-08-05 12:12:25 +03:00
Michael Kret
8131d66f8c
fix(core): Webhook and form baseUrl missing ( #10290 )
2024-08-05 11:04:47 +03:00
Iván Ovejero
aa0a470dce
refactor(core): Clean up event relays (no-changelog) ( #10284 )
2024-08-02 16:52:49 +02:00
Iván Ovejero
a533916628
refactor(core): Decouple post workflow execute event from internal hooks (no-changelog) ( #10280 )
2024-08-02 12:05:06 +02:00
Iván Ovejero
1608d2527b
refactor(core): Port endpoints config (no-changelog) ( #10268 )
2024-07-31 17:45:11 +02:00
Iván Ovejero
3e96b29332
fix(core): Restore log event n8n.workflow.failed ( #10253 )
2024-07-31 12:22:52 +02:00
कारतोफ्फेलस्क्रिप्ट™
1fca3af335
refactor(core): Use type-safe event emitters (no-changelog) ( #10234 )
2024-07-30 13:23:01 +02:00
Iván Ovejero
f1a3791abc
refactor(core): Split out subworkflow policy check from permission checker (no-changelog) ( #10168 )
2024-07-24 12:51:01 +02:00
Iván Ovejero
95b85dd5c1
refactor(core): Port nodes config (no-changelog) ( #10140 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in >
2024-07-23 13:32:50 +02:00
Iván Ovejero
aba1c64500
refactor(core): Rename EventRelay to EventService (no-changelog) ( #10110 )
2024-07-19 12:55:38 +02:00
Iván Ovejero
222a0862bd
refactor(core): Rename EventsService to WorkflowStatisticsService (no-changelog) ( #10107 )
2024-07-19 12:12:44 +02:00
Iván Ovejero
e33a47311f
refactor: Upgrade to TypeScript 5.5 (no-changelog) ( #9828 )
2024-06-24 17:49:59 +02:00
Iván Ovejero
44ea4c73eb
refactor: Remove unused lint directives (no-changelog) ( #9842 )
2024-06-24 12:13:18 +02:00
Iván Ovejero
199dff4fb3
refactor(core): Decouple event bus from internal hooks (no-changelog) ( #9724 )
2024-06-20 12:32:22 +02:00
Csaba Tuncsik
596c472ecc
feat: RBAC ( #8922 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
Co-authored-by: Val <68596159+valya@users.noreply.github.com >
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in >
Co-authored-by: Valya Bullions <valya@n8n.io >
Co-authored-by: Danny Martini <danny@n8n.io >
Co-authored-by: Danny Martini <despair.blue@gmail.com >
Co-authored-by: Iván Ovejero <ivov.src@gmail.com >
Co-authored-by: Omar Ajoue <krynble@gmail.com >
Co-authored-by: oleg <me@olegivaniv.com >
Co-authored-by: Michael Kret <michael.k@radency.com >
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com >
Co-authored-by: Elias Meire <elias@meire.dev >
Co-authored-by: Giulio Andreini <andreini@netseven.it >
Co-authored-by: Giulio Andreini <g.andreini@gmail.com >
Co-authored-by: Ayato Hayashi <go12limchangyong@gmail.com >
2024-05-17 10:53:15 +02:00
Iván Ovejero
7bda92cc7c
refactor(core): Use logger for packages/cli messages (no-changelog) ( #9302 )
2024-05-03 15:24:27 +02:00
oleg
936682eeaa
feat(core): Improve Langsmith traces for AI executions ( #9081 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com >
2024-04-08 22:51:49 +02:00
Val
0ac985133b
fix: Workflows executed from other workflows not stopping ( #9010 )
2024-04-04 10:02:37 +01:00
कारतोफ्फेलस्क्रिप्ट™
072c3db97d
refactor(core): Rename push sessionId to pushRef ( #8905 )
2024-04-03 13:43:14 +02:00
Iván Ovejero
69807a5efb
refactor(core): Unify failed and error execution status (no-changelog) ( #8943 )
2024-03-25 17:52:07 +01:00
कारतोफ्फेलस्क्रिप्ट™
059d281fd1
feat(core): Move execution permission checks earlier in the lifecycle ( #8677 )
2024-02-21 14:47:02 +01:00
Omar Ajoue
7501ad8f3c
feat: Add support for AI log streaming ( #8526 )
...
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com >
2024-02-09 09:41:01 +00:00
कारतोफ्फेलस्क्रिप्ट™
c04f92f7fd
refactor(core): Couple of refactors on WorkflowRunner and ActiveExecutions (no-changelog) ( #8487 )
2024-02-06 18:09:50 +01:00
Danny Martini
39e8754784
fix(core): Don't report executions that have been paused as failed to rudderstack and log streams ( #8501 )
2024-01-31 11:21:15 +01:00
कारतोफ्फेलस्क्रिप्ट™
cc2f0ada76
ci: Enforce noUnusedLocals on all backend and nodes packages (no-changelog) ( #8428 )
2024-01-25 14:33:35 +01:00
कारतोफ्फेलस्क्रिप्ट™
7cdbb424e3
refactor(core): Move methods from WorkflowHelpers into various workflow services (no-changelog) ( #8348 )
2024-01-17 10:16:13 +01:00
कारतोफ्फेलस्क्रिप्ट™
64ceb16af6
refactor(core): Use DI in PermissionChecker (no-changelog) ( #8344 )
2024-01-16 14:15:29 +01:00
Omar Ajoue
e1acb5911a
refactor: Make execution IDs mandatory in BE ( #8299 )
...
Co-authored-by: Iván Ovejero <ivov.src@gmail.com >
2024-01-16 09:53:17 +00:00
कारतोफ्फेलस्क्रिप्ट™
baee47a276
refactor(core): Move all base URLs to UrlService (no-changelog) ( #8141 )
...
This change kept coming up in #6713 , #7773 , and #8135 .
So this PR moves the existing code without actually changing anything,
to help get rid of some of the circular dependencies.
## Review / Merge checklist
- [x] PR title and summary are descriptive.
2023-12-22 15:19:50 +01:00
कारतोफ्फेलस्क्रिप्ट™
21788d9153
fix(core): Remove circular dependency in WorkflowService and ActiveWorkflowRunner ( #8128 )
...
## Summary
A circular dependency between `WorkflowService` and
`ActiveWorkflowRunner` is sometimes causing `this.activeWorkflowRunner`
to be `undefined` in `WorkflowService`.
Breaking this circular dependency should hopefully fix this issue.
## Related tickets and issues
#8122
## Review / Merge checklist
- [x] PR title and summary are descriptive
- [ ] Tests included
2023-12-21 17:37:08 +01:00
Iván Ovejero
1e7a309e63
refactor(core): Make workflow services injectable (no-changelog) ( #8033 )
...
Refactor static workflow service classes into DI-compatible classes
Context: https://n8nio.slack.com/archives/C069HS026UF/p1702466571648889
Up next:
- Inject dependencies into workflow services
- Consolidate workflow controllers into one
- Make workflow controller injectable
- Inject dependencies into workflow controller
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in >
2023-12-15 12:59:56 +01:00
Michael Kret
953a58f18b
feat(n8n Form Trigger Node): Improvements ( #7571 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in >
Co-authored-by: Giulio Andreini <andreini@netseven.it >
2023-12-13 17:00:51 +02:00
Iván Ovejero
18bb87ac0c
test(core): Isolate restore binary data ID in execution lifecycle hooks (no-changelog) ( #7953 )
...
## Summary
Move guard into restore function, move tests into own suite, add tests
for guard.
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-07 17:30:47 +01:00
Omar Ajoue
3ba7deb337
fix: Ensure external hooks post workflow execute run in queue mode ( #7947 )
...
## Summary
Since 1.8.x a refactor removed the call to `workflow.postExecute`'s
External hook from the execution path. This PR adds it back to the
correct place, where workers are supposed to call this, allowing us to
avoid having to re-read the execution data in the caller just for the
hooks.
It is important to have the hooks running in the worker whenever
possible to prevent having to read the full execution data in the
caller.
#### How to test the change:
1. Use the attached hooks file
[external-hooks.txt](https://github.com/n8n-io/n8n/files/13597270/external-hooks.txt )
setting it up via environment variable using `export
EXTERNAL_HOOK_FILES=/path/to/hooks/external-hooks.js`
2. Set up queue mode loading this file in both main and workers
3. See that the message logs will not be displayed without this fix
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-07 10:00:05 +00:00
Iván Ovejero
92bab72cff
fix(core): Fix user comparison in same-user subworkflow caller policy ( #7913 )
...
https://linear.app/n8n/issue/PAY-992
https://community.n8n.io/t/executing-workflow-using-owner-role-created-by-another-user-fails/33443
---------
Co-authored-by: Omar Ajoue <krynble@gmail.com >
2023-12-06 12:27:11 +00:00
Iván Ovejero
61d8aebeaf
fix(core): Allow grace period for binary data deletion after manual execution ( #7889 )
...
https://linear.app/n8n/issue/PAY-1079
2023-12-01 10:13:53 +01:00
Iván Ovejero
c08c5cc37b
refactor(core): Switch plain errors in cli to ApplicationError ( #7857 )
...
Ensure all errors in `cli` are `ApplicationError` or children of it and
contain no variables in the message, to continue normalizing all the
errors we report to Sentry
Follow-up to: https://github.com/n8n-io/n8n/pull/7839
2023-11-29 12:25:10 +01:00
Iván Ovejero
7b8532d3a3
refactor(core): Move execution progress saving to standalone utility (no-changelog) ( #7770 )
...
This PR continues the effort of moving logic inside execution lifecycle
hooks into standalone testable functions, as a stepping stone to
refactoring the hooks themselves.
2023-11-27 13:10:43 +01:00
Iván Ovejero
3459eb6c2f
refactor(core): Include execution progress in save settings (no-changelog) ( #7769 )
2023-11-21 17:33:44 +01:00
Michael Auerswald
0e00dab9f5
fix(core): Consider subworkflows successfully run when in waiting state ( #7699 )
...
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7189
2023-11-14 11:04:24 +01:00
कारतोफ्फेलस्क्रिप्ट™
000e76e3b4
ci(core): Reduce memory usage in tests (part-2) (no-changelog) ( #7671 )
...
This also gets rid of `Db.collection`, which was another source of
circular dependencies.
2023-11-10 15:04:26 +01:00
कारतोफ्फेलस्क्रिप्ट™
5edf722209
ci: Stop disabling linting rules that are explicitly set to warn (no-changelog) ( #7669 )
2023-11-09 14:05:39 +01:00
कारतोफ्फेलस्क्रिप्ट™
35bb42c1b9
refactor(core): Avoid passing around static state like default timezone (no-changelog) ( #7221 )
2023-10-27 14:17:52 +02:00
Iván Ovejero
62c096710f
refactor: Run lintfix (no-changelog) ( #7537 )
...
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
Iván Ovejero
5477e3fb45
refactor(core): Move execution save settings into lifecycle function (no-changelog) ( #7370 )
...
Move the handling of execution save settings into a tested lifecycle
function as discussed with Omar
2023-10-26 14:35:38 +02:00
Iván Ovejero
742c8a8534
fix(core): Ensure execution deletion in worker lifecycle hook ( #7481 )
...
Reported by customer
[here](https://n8nio.slack.com/archives/C05PUALKZHD/p1697446945481249?thread_ts=1697196557.638169&cid=C05PUALKZHD ),
apparently a very old long-standing bug for queue mode. Please review
closely as I am not familiar with queue mode.
2023-10-25 19:13:06 +02:00
कारतोफ्फेलस्क्रिप्ट™
05586a900d
refactor(core): Make Logger a service (no-changelog) ( #7494 )
2023-10-25 16:35:22 +02:00
कारतोफ्फेलस्क्रिप्ट™
b6de910cbe
refactor(core): Abstract away InstanceSettings and encryptionKey into injectable services (no-changelog) ( #7471 )
...
This change ensures that things like `encryptionKey` and `instanceId`
are always available directly where they are needed, instead of passing
them around throughout the code.
2023-10-23 13:39:35 +02:00
Iván Ovejero
0b42d1aa71
refactor(core): Limit soft-deletions to pruning only ( #7469 )
...
Based on customer feedback, we should limit soft deletions to pruning
only, to prevent executions from piling up in very high volume cases.
2023-10-20 15:02:47 +02:00
Iván Ovejero
1a661e6d00
feat(core): Integrate object store as binary data manager ( #7253 )
...
Depends on: #7225 | Story:
[PAY-848](https://linear.app/n8n/issue/PAY-848 )
This PR integrates the object store service as a new binary data manager
for Enterprise.
2023-10-05 15:25:17 +02:00