* feat: remove vue-fragment (no-changelog) * feat: partial design-system migration * feat: migrate info-accordion and info-tip components * feat: migrate several components to vue 3 * feat: migrated several components * feat: migrate several components * feat: migrate several components * feat: migrate several components * feat: re-exported all design system components * fix: fix design for popper components * fix: editor kind of working, lots of issues to fix * fix: fix several vue 3 migration issues * fix: replace @change with @update:modelValue in several places * fix: fix translation linking * fix: fix inline-edit input * fix: fix ndv and dialog design * fix: update parameter input event bindings * fix: rename deprecated lifecycle methods * fix: fix json view mapping * build: update lock file * fix(editor): revisit last conflict with master and fix issues * fix(editor): revisit last conflict with master and fix issues * fix: fix expression editor bug causing code mirror to no longer be reactive * fix: fix resource locator bug * fix: fix vue-agile integration * fix: remove global import for vue-agile * fix: replace element-plus buttons with n8n-buttons everywhere * fix(editor): Fix various element-plus styles (#6571) * fix(editor): Fix various element-plus styles Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Remove debugging code Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Address PR comments Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix(editor): Fix loading in production mode [Vue 3] (#6578) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix(editor): First round of e2e tests fixes with Vue 3 (#6579) * fix(editor): Fix broken smoke and workflow list e2e tests * ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests * feat: add vue 3 eslint rules and fix issues * fix: fix tags-dropdown * fix: fix white-space issues caused by i18n-t * fix: rename non-generic click events * fix: fix search in resources list layout * fix: fix datatable paginator * fix: fix popper select caret and dropdown size * fix: add width to action-dropdown * fix: fix workflow settings icon not being hidden * fix: refactor newly added code * fix: fix merge issue * fix: fix ndv credentials watcher * fix: fix workflow saving and grabber notch * fix: fix nodes list panel transition * fix: fix node title visibility * fix: fix data unpinning * fix: fix value access * fix: show input panel only if trigger panel enabled or not trigger node * fix: fix tags dropdown and executions status spcing * fix(editor): Prevent execution list to load back when leaving the route (#6697) fix(editor): prevent execution list to load back when leaving the route * fix: fix drawer visibility * fix: fix expression toggle padding * fix: fix expressions editor styling * chore: prepare for testing * fix: fix styling for el-button without patching * test: fix unit tests in design-system * test: fix most unit tests * fix: remove import cycle. * fix: fix personalization modal tests * fix further resource mapper test adjustments * fix: fix multiple tests and n8n-route attr duplication * fix: fix source control tets * fix: fixed remaining unit tests * fix: fix workflows and credentials e2e tests * fix: fix localizeNodeNames * fix: update ndv e2e tests * fix: fix popper left placement arrow * fix: fix 5-ndv e2e tests * fix: fix 6-code-node e2e tests * fix(editor): Drop click outside directive from NodeCreator (#6716) * fix(editor): Drop click outside directive from NodeCreator * fix(editor): make sure mouseup outside is unbound at least before the component is unmounted * fix: fix 10-settings-log-streaming e2e tests * fix: fix node redrawing * fix: fix tooltip buttons styling * fix: fix varous e2e suites * fix: fix 15-scheduler-node e2e suite * fix: fix route watcher * fix: fixed param name update and credential edit * feat: update event names * refactor: Remove deprecated `$data` (#6576) Co-authored-by: Alex Grozav <alex@grozav.com> * fix: fix 17-sharing e2e suite * fix: fix tags dropdown * fix: fix tags manager * fix(editor): move :deep selectors to a separate scoped style block * fix: fix sticky component and inline text edit * fix: update e2e tests * fix: remove button override references * fix(editor): Adjust spacing in templates for Vue 3 (#6744) * fix(editor): Adjust spacing in templates * fix: Undo unneeded change * fix: Undo unneeded change * fix(editor): Adjust NDV height for Vue 3 (#6742) fix(editor): Adjust NDV height * fix(editor): Restore collapsed sidebar items for Vue 3 (#6743) fix(editor): Restore collapsed sidebar items * fix: fix linting issues * fix: fix design-system deps * fix: post-merge fixes * fix: update tests * fix: increase timeout for executionslist tets * chore: fix linting issue * fix: fix 14-mapping e2e tests in ci * fix: re-enable tests * fix: fix workflow duplication e2e tests after tags update * fix(editor): Change component prop to be typed * fix: fix tags dropdown in duplicate wf modal * fix: fix focus behaviour in tags selector * fix: fix tag creation * fix: fix log streaming e2e race condition * fix(editor): Fix Vue 3 linting issues (#6748) * fix(editor): Fix Vue 3 linting issues Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix MainSidebar linter issues * revert pnpm lock * update pnpm lock file --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Alex Grozav <alex@grozav.com> * fix(editor): Some css fixes for vue3 branch (#6749) * ✨ Fixing filter button height * ✨ Update input modal button position * ✨ Updating tags styling * ✨ Fix event logging settings spacing * 👕 Fixing lint errors * fix: fix linting issues * Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix: fix css issue * fix(editor): Lint fix * fix(editor): Fix settings initialisation (#6750) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix: fix initial settings loading * fix: replace realClick with click force * fix: fix randomly failing mapping e2e tests * fix(editor): Fix menu item event handling * fix: fix resource filters dropdown events (#6752) * fix: fix resource filters dropdown events * fix: remove teleported:false * fix: fix event selection event naming (#6753) * fix: removed console.log (#6754) * fix: rever await nextTick changes * fix: redo linting changes * fix(editor): Redraw node connections if adding more than one node to canvas (#6755) * fix(editor): Redraw node connections if adding more than one node to canvas Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Update position before connection two nodes * Lint fix --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Alex Grozav <alex@grozav.com> * fix(editor): Fix `ResourceMapper` unit tests (#6758) * ✔️ Fix matching columns test * ✔️ Fix multiple matching columns test * ✔️ Removing `skip` from the last test * fix: Allow pasting a big workflow (#6760) * fix: pasting a big workflow * chore: update comment * refactor: move try/catch to function * refactor: move try/catch to function * fix(editor): Fix modal layer width * fix: fix position changes * fix: undo it.only * fix: make undo/redo multiple steps more verbose * fix: Fix value survey styles (#6764) * fix: fix value survey styles * fix: lint * Revert "fix: lint" 72869c431f1448861df021be041b61c62f1e3118 * fix: lint * fix(editor): Fix collapsed sub menu * fix: Fix drawer animation (#6767) fix: drawer animation * fix(editor): Fix source control buttons (#6769) * fix(editor): Fix App loading & auth (#6768) * fix(editor): Fix App loading & auth Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Await promises Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Fix eslint error Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Csaba Tuncsik <csaba@n8n.io> Co-authored-by: OlegIvaniv <me@olegivaniv.com> Co-authored-by: Milorad FIlipović <milorad@n8n.io> Co-authored-by: Iván Ovejero <ivov.src@gmail.com> Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
292 lines
9.8 KiB
TypeScript
292 lines
9.8 KiB
TypeScript
import { WorkflowPage, NDV } from '../pages';
|
|
import { v4 as uuid } from 'uuid';
|
|
|
|
const workflowPage = new WorkflowPage();
|
|
const ndv = new NDV();
|
|
|
|
describe('NDV', () => {
|
|
beforeEach(() => {
|
|
workflowPage.actions.visit();
|
|
workflowPage.actions.renameWorkflow(uuid());
|
|
workflowPage.actions.saveWorkflowOnButtonClick();
|
|
});
|
|
|
|
it('should show up when double clicked on a node and close when Back to canvas clicked', () => {
|
|
workflowPage.actions.addInitialNodeToCanvas('Manual');
|
|
workflowPage.getters.canvasNodes().first().dblclick();
|
|
ndv.getters.container().should('be.visible');
|
|
ndv.getters.backToCanvas().click();
|
|
ndv.getters.container().should('not.be.visible');
|
|
});
|
|
|
|
it('should test webhook node', () => {
|
|
workflowPage.actions.addInitialNodeToCanvas('Webhook');
|
|
workflowPage.getters.canvasNodes().first().dblclick();
|
|
|
|
ndv.actions.execute();
|
|
ndv.getters.copyInput().click();
|
|
|
|
cy.grantBrowserPermissions('clipboardReadWrite', 'clipboardSanitizedWrite');
|
|
|
|
cy.readClipboard().then((url) => {
|
|
cy.request({
|
|
method: 'GET',
|
|
url,
|
|
}).then((resp) => {
|
|
expect(resp.status).to.eq(200);
|
|
});
|
|
});
|
|
|
|
ndv.getters.outputDisplayMode().should('have.length.at.least', 1).and('be.visible');
|
|
});
|
|
|
|
it('should change input', () => {
|
|
cy.createFixtureWorkflow('NDV-test-select-input.json', `NDV test select input ${uuid()}`);
|
|
workflowPage.actions.zoomToFit();
|
|
workflowPage.getters.canvasNodes().last().dblclick();
|
|
ndv.getters.inputSelect().click();
|
|
ndv.getters.inputOption().last().click();
|
|
ndv.getters.inputDataContainer().find('[class*=schema_]').should('exist');
|
|
ndv.getters.inputDataContainer().should('contain', 'start');
|
|
});
|
|
|
|
it('should show correct validation state for resource locator params', () => {
|
|
workflowPage.actions.addNodeToCanvas('Typeform', true, true);
|
|
ndv.getters.container().should('be.visible');
|
|
cy.get('.has-issues').should('have.length', 0);
|
|
cy.get('[class*=hasIssues]').should('have.length', 0);
|
|
ndv.getters.backToCanvas().click();
|
|
// Both credentials and resource locator errors should be visible
|
|
workflowPage.actions.openNode('Typeform');
|
|
cy.get('.has-issues').should('have.length', 1);
|
|
cy.get('[class*=hasIssues]').should('have.length', 1);
|
|
});
|
|
|
|
it('should show validation errors only after blur or re-opening of NDV', () => {
|
|
workflowPage.actions.addNodeToCanvas('Manual');
|
|
workflowPage.actions.addNodeToCanvas('Airtable', true, true, 'Search records');
|
|
ndv.getters.container().should('be.visible');
|
|
// cy.get('.has-issues').should('have.length', 0);
|
|
ndv.getters.parameterInput('table').find('input').eq(1).focus().blur();
|
|
ndv.getters.parameterInput('base').find('input').eq(1).focus().blur();
|
|
cy.get('.has-issues').should('have.length', 0);
|
|
ndv.getters.backToCanvas().click();
|
|
workflowPage.actions.openNode('Airtable');
|
|
cy.get('.has-issues').should('have.length', 2);
|
|
cy.get('[class*=hasIssues]').should('have.length', 1);
|
|
});
|
|
|
|
it('should show all validation errors when opening pasted node', () => {
|
|
cy.fixture('Test_workflow_ndv_errors.json').then((data) => {
|
|
cy.get('body').paste(JSON.stringify(data));
|
|
workflowPage.getters.canvasNodes().should('have.have.length', 1);
|
|
workflowPage.actions.openNode('Airtable');
|
|
cy.get('.has-issues').should('have.length', 3);
|
|
cy.get('[class*=hasIssues]').should('have.length', 1);
|
|
});
|
|
});
|
|
|
|
it('should save workflow using keyboard shortcut from NDV', () => {
|
|
workflowPage.actions.addNodeToCanvas('Manual');
|
|
workflowPage.actions.addNodeToCanvas('Set', true, true);
|
|
ndv.getters.container().should('be.visible');
|
|
workflowPage.actions.saveWorkflowUsingKeyboardShortcut();
|
|
workflowPage.getters.isWorkflowSaved();
|
|
});
|
|
|
|
describe('test output schema view', () => {
|
|
const schemaKeys = [
|
|
'id',
|
|
'name',
|
|
'email',
|
|
'notes',
|
|
'country',
|
|
'created',
|
|
'objectValue',
|
|
'prop1',
|
|
'prop2',
|
|
];
|
|
function setupSchemaWorkflow() {
|
|
cy.createFixtureWorkflow('Test_workflow_schema_test.json', `NDV test schema view ${uuid()}`);
|
|
workflowPage.actions.zoomToFit();
|
|
workflowPage.actions.openNode('Set');
|
|
ndv.actions.execute();
|
|
}
|
|
|
|
it('should switch to output schema view and validate it', () => {
|
|
setupSchemaWorkflow();
|
|
ndv.getters.outputDisplayMode().children().should('have.length', 3);
|
|
ndv.getters.outputDisplayMode().find('[class*=active]').should('contain', 'Table');
|
|
ndv.actions.switchOutputMode('Schema');
|
|
ndv.getters.outputDisplayMode().find('[class*=active]').should('contain', 'Schema');
|
|
|
|
schemaKeys.forEach((key) => {
|
|
ndv.getters
|
|
.outputPanel()
|
|
.find('[data-test-id=run-data-schema-item]')
|
|
.contains(key)
|
|
.should('exist');
|
|
});
|
|
});
|
|
it('should preserve schema view after execution', () => {
|
|
setupSchemaWorkflow();
|
|
ndv.actions.switchOutputMode('Schema');
|
|
ndv.actions.execute();
|
|
ndv.getters.outputDisplayMode().find('[class*=active]').should('contain', 'Schema');
|
|
});
|
|
it('should collapse and expand nested schema object', () => {
|
|
setupSchemaWorkflow();
|
|
const expandedObjectProps = ['prop1', 'prop2'];
|
|
const getObjectValueItem = () =>
|
|
ndv.getters
|
|
.outputPanel()
|
|
.find('[data-test-id=run-data-schema-item]')
|
|
.filter(':contains("objectValue")');
|
|
ndv.actions.switchOutputMode('Schema');
|
|
|
|
expandedObjectProps.forEach((key) => {
|
|
ndv.getters
|
|
.outputPanel()
|
|
.find('[data-test-id=run-data-schema-item]')
|
|
.contains(key)
|
|
.should('be.visible');
|
|
});
|
|
getObjectValueItem().find('label').click();
|
|
expandedObjectProps.forEach((key) => {
|
|
ndv.getters
|
|
.outputPanel()
|
|
.find('[data-test-id=run-data-schema-item]')
|
|
.contains(key)
|
|
.should('not.be.visible');
|
|
});
|
|
});
|
|
it('should not display pagination for schema', () => {
|
|
setupSchemaWorkflow();
|
|
ndv.getters.backToCanvas().click();
|
|
workflowPage.getters.canvasNodeByName('Set').click();
|
|
workflowPage.actions.addNodeToCanvas(
|
|
'Customer Datastore (n8n training)',
|
|
true,
|
|
true,
|
|
'Get All People',
|
|
);
|
|
ndv.actions.execute();
|
|
ndv.getters.outputPanel().contains('25 items').should('exist');
|
|
ndv.getters.outputPanel().find('[class*=_pagination]').should('exist');
|
|
ndv.actions.switchOutputMode('Schema');
|
|
ndv.getters.outputPanel().find('[class*=_pagination]').should('not.exist');
|
|
ndv.actions.switchOutputMode('JSON');
|
|
ndv.getters.outputPanel().find('[class*=_pagination]').should('exist');
|
|
});
|
|
it('should display large schema', () => {
|
|
cy.createFixtureWorkflow(
|
|
'Test_workflow_schema_test_pinned_data.json',
|
|
`NDV test schema view ${uuid()}`,
|
|
);
|
|
workflowPage.actions.zoomToFit();
|
|
workflowPage.actions.openNode('Set');
|
|
|
|
ndv.getters.outputPanel().contains('20 items').should('exist');
|
|
ndv.getters.outputPanel().find('[class*=_pagination]').should('exist');
|
|
ndv.actions.switchOutputMode('Schema');
|
|
ndv.getters.outputPanel().find('[class*=_pagination]').should('not.exist');
|
|
ndv.getters
|
|
.outputPanel()
|
|
.find('[data-test-id=run-data-schema-item] [data-test-id=run-data-schema-item]')
|
|
.should('have.length', 20);
|
|
});
|
|
});
|
|
|
|
it('can link and unlink run selectors between input and output', () => {
|
|
cy.createFixtureWorkflow('Test_workflow_5.json', 'Test');
|
|
workflowPage.actions.zoomToFit();
|
|
workflowPage.actions.executeWorkflow();
|
|
workflowPage.actions.openNode('Set3');
|
|
|
|
ndv.getters
|
|
.inputRunSelector()
|
|
.should('exist')
|
|
.find('input')
|
|
.should('include.value', '2 of 2 (6 items)');
|
|
ndv.getters
|
|
.outputRunSelector()
|
|
.should('exist')
|
|
.find('input')
|
|
.should('include.value', '2 of 2 (6 items)');
|
|
|
|
ndv.actions.switchInputMode('Table');
|
|
ndv.actions.switchOutputMode('Table');
|
|
|
|
ndv.actions.changeOutputRunSelector('1 of 2 (6 items)');
|
|
ndv.getters.inputRunSelector().find('input').should('include.value', '1 of 2 (6 items)');
|
|
ndv.getters.inputTbodyCell(1, 0).should('have.text', '1111');
|
|
ndv.getters.outputTbodyCell(1, 0).should('have.text', '1111');
|
|
|
|
ndv.getters.inputTbodyCell(1, 0).click(); // remove tooltip
|
|
ndv.actions.changeInputRunSelector('2 of 2 (6 items)');
|
|
ndv.getters.outputRunSelector().find('input').should('include.value', '2 of 2 (6 items)');
|
|
|
|
// unlink
|
|
ndv.actions.toggleOutputRunLinking();
|
|
ndv.getters.inputTbodyCell(1, 0).click(); // remove tooltip
|
|
ndv.actions.changeOutputRunSelector('1 of 2 (6 items)');
|
|
ndv.getters
|
|
.inputRunSelector()
|
|
.should('exist')
|
|
.find('input')
|
|
.should('include.value', '2 of 2 (6 items)');
|
|
|
|
// link again
|
|
ndv.actions.toggleOutputRunLinking();
|
|
ndv.getters.inputTbodyCell(1, 0).click(); // remove tooltip
|
|
ndv.getters.inputRunSelector().find('input').should('include.value', '1 of 2 (6 items)');
|
|
|
|
// unlink again
|
|
ndv.actions.toggleInputRunLinking();
|
|
ndv.getters.inputTbodyCell(1, 0).click(); // remove tooltip
|
|
ndv.actions.changeInputRunSelector('2 of 2 (6 items)');
|
|
ndv.getters.outputRunSelector().find('input').should('include.value', '1 of 2 (6 items)');
|
|
|
|
// link again
|
|
ndv.actions.toggleInputRunLinking();
|
|
ndv.getters.inputTbodyCell(1, 0).click(); // remove tooltip
|
|
ndv.getters.outputRunSelector().find('input').should('include.value', '2 of 2 (6 items)');
|
|
});
|
|
|
|
it('should display parameter hints correctly', () => {
|
|
workflowPage.actions.visit();
|
|
|
|
cy.createFixtureWorkflow('Test_workflow_3.json', `My test workflow`);
|
|
workflowPage.actions.openNode('Set1');
|
|
|
|
ndv.actions.typeIntoParameterInput('value', '='); // switch to expressions
|
|
|
|
[
|
|
{
|
|
input: 'hello',
|
|
},
|
|
{
|
|
input: '',
|
|
output: '[empty]',
|
|
},
|
|
{
|
|
input: ' test',
|
|
},
|
|
{
|
|
input: ' ',
|
|
},
|
|
{
|
|
input: '<div></div>',
|
|
},
|
|
].forEach(({ input, output }) => {
|
|
if (input) {
|
|
ndv.actions.typeIntoParameterInput('value', input);
|
|
}
|
|
ndv.getters.parameterInput('name').click(); // remove focus from input, hide expression preview
|
|
|
|
ndv.actions.validateExpressionPreview('value', output || input);
|
|
ndv.getters.parameterInput('value').clear();
|
|
});
|
|
});
|
|
});
|