Iván Ovejero 8cb9c6b3ea ci: Introduce no-plain-errors lint rule for BE packages (no-changelog) (#7961) ...

## Summary
Require `ApplicationError` or its child classes instead of plain `Error`
in BE packages. This ensures the error will be normalized when reported
to Sentry, if applicable.

Follow-up to:
https://github.com/n8n-io/n8n/pulls?q=is%3Apr+is%3Aclosed+applicationerror

...

#### How to test the change:
1. ...


## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers

...


## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
  >
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227)
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce)
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e).

2023-12-08 12:51:49 +01:00

..

auth

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

collaboration

…

commands

fix(core): Fix expression evaluator filename typo (no-changelog) (#7960)

2023-12-07 17:50:49 +01:00

config

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

controllers

fix(core): Ensure inviter and invitee are set correctly in invite link (#7943)

2023-12-07 10:53:31 +01:00

credentials

fix: Restrict updating/deleting of shared but not owned credentials (#7950)

2023-12-07 10:35:40 +00:00

databases

feat: Replace owner checks with scope checks (no-changelog) (#7846)

2023-11-29 14:48:36 +00:00

decorators

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

environments

ci: Introduce no-plain-errors lint rule for BE packages (no-changelog) (#7961)

2023-12-08 12:51:49 +01:00

errors

refactor: Unify severity and level for all application errors for Sentry (no-changelog) (#7956)

2023-12-07 16:57:02 +01:00

eventbus

feat: Add initial scope checks via decorators (#7737)

2023-11-28 11:41:34 +00:00

executionLifecycleHooks

test(core): Isolate restore binary data ID in execution lifecycle hooks (no-changelog) (#7953)

2023-12-07 17:30:47 +01:00

executions

feat: Replace owner checks with scope checks (no-changelog) (#7846)

2023-11-29 14:48:36 +00:00

ExternalSecrets

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

helpers

…

Ldap

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

license

refactor(core): Reorganize error hierarchy in cli package (no-changelog) (#7839)

2023-11-28 10:19:27 +01:00

Mfa

…

middlewares

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

permissions

fix: Restrict updating/deleting of shared but not owned credentials (#7950)

2023-12-07 10:35:40 +00:00

posthog

…

PublicApi

feat: Add admin role to public API (no-changelog) (#7933)

2023-12-05 15:00:14 +00:00

push

feat(core): Update LLM applications building support (no-changelog) (#7710)

2023-11-28 16:47:28 +01:00

security-audit

…

services

fix(core): Ensure inviter and invitee are set correctly in invite link (#7943)

2023-12-07 10:53:31 +01:00

sso

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

telemetry

…

types

…

UserManagement

refactor: Unify severity and level for all application errors for Sentry (no-changelog) (#7956)

2023-12-07 16:57:02 +01:00

workflows

fix(core): Consolidate ownership and sharing data on workflows and credentials (#7920)

2023-12-05 10:11:18 +01:00

AbstractServer.ts

refactor(core): Reorganize error hierarchy in cli package (no-changelog) (#7839)

2023-11-28 10:19:27 +01:00

ActivationErrors.service.ts

…

ActiveExecutions.ts

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

ActiveWebhooks.ts

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

ActiveWorkflowRunner.ts

feat: Replace owner checks with scope checks (no-changelog) (#7846)

2023-11-29 14:48:36 +00:00

constants.ts

feat: Add AI tool building capabilities (#7336)

2023-11-29 12:13:55 +01:00

CrashJournal.ts

…

CredentialsHelper.ts

feat: Replace owner checks with scope checks (no-changelog) (#7846)

2023-11-29 14:48:36 +00:00

CredentialsOverwrites.ts

…

CredentialTypes.ts

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

curlconverter.d.ts

…

CurlConverterHelper.ts

…

Db.ts

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

ErrorReporting.ts

feat(core): Add package name tag to Sentry errors (no-changelog) (#7958)

2023-12-08 11:30:06 +01:00

ExpressionEvaluator.ts

fix(core): Fix expression evaluator filename typo (no-changelog) (#7960)

2023-12-07 17:50:49 +01:00

ExternalHooks.ts

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

GenericHelpers.ts

refactor(core): Reorganize error hierarchy in cli package (no-changelog) (#7839)

2023-11-28 10:19:27 +01:00

index.ts

…

Interfaces.ts

…

InternalHooks.ts

…

jest.d.ts

…

License.ts

feat(core): Set up endpoint for all existing roles with license flag (#7834)

2023-11-28 14:16:47 +01:00

LoadNodesAndCredentials.ts

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

Logger.ts

…

NodeTypes.ts

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

Queue.ts

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

requests.ts

fix(core): Consolidate ownership and sharing data on workflows and credentials (#7920)

2023-12-05 10:11:18 +01:00

ResponseHelper.ts

refactor(core): Reorganize error hierarchy in cli package (no-changelog) (#7839)

2023-11-28 10:19:27 +01:00

SecretsHelpers.ts

…

Server.ts

feat: Replace owner checks with scope checks (no-changelog) (#7846)

2023-11-29 14:48:36 +00:00

sse-channel.d.ts

…

TestWebhooks.ts

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

utils.ts

…

WaitingWebhooks.ts

refactor(core): Reorganize error hierarchy in cli package (no-changelog) (#7839)

2023-11-28 10:19:27 +01:00

WaitTracker.ts

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

WebhookHelpers.ts

fix(Webhook Node): Binary data handling (#7804)

2023-12-06 17:46:40 +02:00

WebhookServer.ts

…

WorkflowCredentials.ts

refactor(core): Switch plain errors in cli to ApplicationError (#7857)

2023-11-29 12:25:10 +01:00

WorkflowExecuteAdditionalData.ts

test(core): Isolate restore binary data ID in execution lifecycle hooks (no-changelog) (#7953)

2023-12-07 17:30:47 +01:00

WorkflowHelpers.ts

fix(core): Fix user comparison in same-user subworkflow caller policy (#7913)

2023-12-06 12:27:11 +00:00

WorkflowRunner.ts

fix: Ensure external hooks post workflow execute run in queue mode (#7947)

2023-12-07 10:00:05 +00:00

WorkflowRunnerProcess.ts

…