* feat: remove vue-fragment (no-changelog) * feat: partial design-system migration * feat: migrate info-accordion and info-tip components * feat: migrate several components to vue 3 * feat: migrated several components * feat: migrate several components * feat: migrate several components * feat: migrate several components * feat: re-exported all design system components * fix: fix design for popper components * fix: editor kind of working, lots of issues to fix * fix: fix several vue 3 migration issues * fix: replace @change with @update:modelValue in several places * fix: fix translation linking * fix: fix inline-edit input * fix: fix ndv and dialog design * fix: update parameter input event bindings * fix: rename deprecated lifecycle methods * fix: fix json view mapping * build: update lock file * fix(editor): revisit last conflict with master and fix issues * fix(editor): revisit last conflict with master and fix issues * fix: fix expression editor bug causing code mirror to no longer be reactive * fix: fix resource locator bug * fix: fix vue-agile integration * fix: remove global import for vue-agile * fix: replace element-plus buttons with n8n-buttons everywhere * fix(editor): Fix various element-plus styles (#6571) * fix(editor): Fix various element-plus styles Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Remove debugging code Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Address PR comments Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix(editor): Fix loading in production mode [Vue 3] (#6578) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix(editor): First round of e2e tests fixes with Vue 3 (#6579) * fix(editor): Fix broken smoke and workflow list e2e tests * ✔️ Fix failing canvas action tests. Updating some selectors used in credentials and workflow tests * feat: add vue 3 eslint rules and fix issues * fix: fix tags-dropdown * fix: fix white-space issues caused by i18n-t * fix: rename non-generic click events * fix: fix search in resources list layout * fix: fix datatable paginator * fix: fix popper select caret and dropdown size * fix: add width to action-dropdown * fix: fix workflow settings icon not being hidden * fix: refactor newly added code * fix: fix merge issue * fix: fix ndv credentials watcher * fix: fix workflow saving and grabber notch * fix: fix nodes list panel transition * fix: fix node title visibility * fix: fix data unpinning * fix: fix value access * fix: show input panel only if trigger panel enabled or not trigger node * fix: fix tags dropdown and executions status spcing * fix(editor): Prevent execution list to load back when leaving the route (#6697) fix(editor): prevent execution list to load back when leaving the route * fix: fix drawer visibility * fix: fix expression toggle padding * fix: fix expressions editor styling * chore: prepare for testing * fix: fix styling for el-button without patching * test: fix unit tests in design-system * test: fix most unit tests * fix: remove import cycle. * fix: fix personalization modal tests * fix further resource mapper test adjustments * fix: fix multiple tests and n8n-route attr duplication * fix: fix source control tets * fix: fixed remaining unit tests * fix: fix workflows and credentials e2e tests * fix: fix localizeNodeNames * fix: update ndv e2e tests * fix: fix popper left placement arrow * fix: fix 5-ndv e2e tests * fix: fix 6-code-node e2e tests * fix(editor): Drop click outside directive from NodeCreator (#6716) * fix(editor): Drop click outside directive from NodeCreator * fix(editor): make sure mouseup outside is unbound at least before the component is unmounted * fix: fix 10-settings-log-streaming e2e tests * fix: fix node redrawing * fix: fix tooltip buttons styling * fix: fix varous e2e suites * fix: fix 15-scheduler-node e2e suite * fix: fix route watcher * fix: fixed param name update and credential edit * feat: update event names * refactor: Remove deprecated `$data` (#6576) Co-authored-by: Alex Grozav <alex@grozav.com> * fix: fix 17-sharing e2e suite * fix: fix tags dropdown * fix: fix tags manager * fix(editor): move :deep selectors to a separate scoped style block * fix: fix sticky component and inline text edit * fix: update e2e tests * fix: remove button override references * fix(editor): Adjust spacing in templates for Vue 3 (#6744) * fix(editor): Adjust spacing in templates * fix: Undo unneeded change * fix: Undo unneeded change * fix(editor): Adjust NDV height for Vue 3 (#6742) fix(editor): Adjust NDV height * fix(editor): Restore collapsed sidebar items for Vue 3 (#6743) fix(editor): Restore collapsed sidebar items * fix: fix linting issues * fix: fix design-system deps * fix: post-merge fixes * fix: update tests * fix: increase timeout for executionslist tets * chore: fix linting issue * fix: fix 14-mapping e2e tests in ci * fix: re-enable tests * fix: fix workflow duplication e2e tests after tags update * fix(editor): Change component prop to be typed * fix: fix tags dropdown in duplicate wf modal * fix: fix focus behaviour in tags selector * fix: fix tag creation * fix: fix log streaming e2e race condition * fix(editor): Fix Vue 3 linting issues (#6748) * fix(editor): Fix Vue 3 linting issues Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix MainSidebar linter issues * revert pnpm lock * update pnpm lock file --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Alex Grozav <alex@grozav.com> * fix(editor): Some css fixes for vue3 branch (#6749) * ✨ Fixing filter button height * ✨ Update input modal button position * ✨ Updating tags styling * ✨ Fix event logging settings spacing * 👕 Fixing lint errors * fix: fix linting issues * Revert to `// eslint-disable-next-line @typescript-eslint/no-misused-promises` disabling of mixins init Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix: fix css issue * fix(editor): Lint fix * fix(editor): Fix settings initialisation (#6750) Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * fix: fix initial settings loading * fix: replace realClick with click force * fix: fix randomly failing mapping e2e tests * fix(editor): Fix menu item event handling * fix: fix resource filters dropdown events (#6752) * fix: fix resource filters dropdown events * fix: remove teleported:false * fix: fix event selection event naming (#6753) * fix: removed console.log (#6754) * fix: rever await nextTick changes * fix: redo linting changes * fix(editor): Redraw node connections if adding more than one node to canvas (#6755) * fix(editor): Redraw node connections if adding more than one node to canvas Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Update position before connection two nodes * Lint fix --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Alex Grozav <alex@grozav.com> * fix(editor): Fix `ResourceMapper` unit tests (#6758) * ✔️ Fix matching columns test * ✔️ Fix multiple matching columns test * ✔️ Removing `skip` from the last test * fix: Allow pasting a big workflow (#6760) * fix: pasting a big workflow * chore: update comment * refactor: move try/catch to function * refactor: move try/catch to function * fix(editor): Fix modal layer width * fix: fix position changes * fix: undo it.only * fix: make undo/redo multiple steps more verbose * fix: Fix value survey styles (#6764) * fix: fix value survey styles * fix: lint * Revert "fix: lint" 72869c431f1448861df021be041b61c62f1e3118 * fix: lint * fix(editor): Fix collapsed sub menu * fix: Fix drawer animation (#6767) fix: drawer animation * fix(editor): Fix source control buttons (#6769) * fix(editor): Fix App loading & auth (#6768) * fix(editor): Fix App loading & auth Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Await promises Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> * Fix eslint error Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> --------- Signed-off-by: Oleg Ivaniv <me@olegivaniv.com> Co-authored-by: Csaba Tuncsik <csaba@n8n.io> Co-authored-by: OlegIvaniv <me@olegivaniv.com> Co-authored-by: Milorad FIlipović <milorad@n8n.io> Co-authored-by: Iván Ovejero <ivov.src@gmail.com> Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
378 lines
10 KiB
Vue
378 lines
10 KiB
Vue
<script lang="ts" setup>
|
|
import { computed, ref, onBeforeMount, onBeforeUnmount } from 'vue';
|
|
import {
|
|
useEnvironmentsStore,
|
|
useUIStore,
|
|
useSettingsStore,
|
|
useUsersStore,
|
|
useSourceControlStore,
|
|
} from '@/stores';
|
|
import { useI18n, useTelemetry, useToast, useMessage } from '@/composables';
|
|
|
|
import ResourcesListLayout from '@/components/layouts/ResourcesListLayout.vue';
|
|
import VariablesRow from '@/components/VariablesRow.vue';
|
|
|
|
import { EnterpriseEditionFeature } from '@/constants';
|
|
import type {
|
|
DatatableColumn,
|
|
EnvironmentVariable,
|
|
TemporaryEnvironmentVariable,
|
|
} from '@/Interface';
|
|
import { uid } from 'n8n-design-system/utils';
|
|
import { getVariablesPermissions } from '@/permissions';
|
|
|
|
const settingsStore = useSettingsStore();
|
|
const environmentsStore = useEnvironmentsStore();
|
|
const usersStore = useUsersStore();
|
|
const uiStore = useUIStore();
|
|
const telemetry = useTelemetry();
|
|
const i18n = useI18n();
|
|
const message = useMessage();
|
|
const sourceControlStore = useSourceControlStore();
|
|
let sourceControlStoreUnsubscribe = () => {};
|
|
|
|
const layoutRef = ref<InstanceType<typeof ResourcesListLayout> | null>(null);
|
|
|
|
const { showError } = useToast();
|
|
|
|
const TEMPORARY_VARIABLE_UID_BASE = '@tmpvar';
|
|
|
|
const allVariables = ref<Array<EnvironmentVariable | TemporaryEnvironmentVariable>>([]);
|
|
const editMode = ref<Record<string, boolean>>({});
|
|
|
|
const permissions = getVariablesPermissions(usersStore.currentUser);
|
|
|
|
const isFeatureEnabled = computed(() =>
|
|
settingsStore.isEnterpriseFeatureEnabled(EnterpriseEditionFeature.Variables),
|
|
);
|
|
const canCreateVariables = computed(() => isFeatureEnabled.value && permissions.create);
|
|
|
|
const datatableColumns = computed<DatatableColumn[]>(() => [
|
|
{
|
|
id: 0,
|
|
path: 'name',
|
|
label: i18n.baseText('variables.table.key'),
|
|
classes: ['variables-key-column'],
|
|
},
|
|
{
|
|
id: 1,
|
|
path: 'value',
|
|
label: i18n.baseText('variables.table.value'),
|
|
classes: ['variables-value-column'],
|
|
},
|
|
{
|
|
id: 2,
|
|
path: 'usage',
|
|
label: i18n.baseText('variables.table.usage'),
|
|
classes: ['variables-usage-column'],
|
|
},
|
|
...(isFeatureEnabled.value
|
|
? [
|
|
{
|
|
id: 3,
|
|
path: 'actions',
|
|
label: '',
|
|
},
|
|
]
|
|
: []),
|
|
]);
|
|
|
|
const contextBasedTranslationKeys = computed(() => uiStore.contextBasedTranslationKeys);
|
|
|
|
const newlyAddedVariableIds = ref<number[]>([]);
|
|
|
|
const nameSortFn = (a: EnvironmentVariable, b: EnvironmentVariable, direction: 'asc' | 'desc') => {
|
|
if (`${a.id}`.startsWith(TEMPORARY_VARIABLE_UID_BASE)) {
|
|
return -1;
|
|
} else if (`${b.id}`.startsWith(TEMPORARY_VARIABLE_UID_BASE)) {
|
|
return 1;
|
|
} else if (
|
|
newlyAddedVariableIds.value.includes(a.id) &&
|
|
newlyAddedVariableIds.value.includes(b.id)
|
|
) {
|
|
return newlyAddedVariableIds.value.indexOf(a.id) - newlyAddedVariableIds.value.indexOf(b.id);
|
|
} else if (newlyAddedVariableIds.value.includes(a.id)) {
|
|
return -1;
|
|
} else if (newlyAddedVariableIds.value.includes(b.id)) {
|
|
return 1;
|
|
}
|
|
|
|
return direction === 'asc'
|
|
? displayName(a).trim().localeCompare(displayName(b).trim())
|
|
: displayName(b).trim().localeCompare(displayName(a).trim());
|
|
};
|
|
const sortFns = {
|
|
nameAsc: (a: EnvironmentVariable, b: EnvironmentVariable) => {
|
|
return nameSortFn(a, b, 'asc');
|
|
},
|
|
nameDesc: (a: EnvironmentVariable, b: EnvironmentVariable) => {
|
|
return nameSortFn(a, b, 'desc');
|
|
},
|
|
};
|
|
|
|
function resetNewVariablesList() {
|
|
newlyAddedVariableIds.value = [];
|
|
}
|
|
|
|
async function initialize() {
|
|
await environmentsStore.fetchAllVariables();
|
|
|
|
allVariables.value = [...environmentsStore.variables];
|
|
}
|
|
|
|
function addTemporaryVariable() {
|
|
const temporaryVariable: TemporaryEnvironmentVariable = {
|
|
id: uid(TEMPORARY_VARIABLE_UID_BASE),
|
|
key: '',
|
|
value: '',
|
|
};
|
|
|
|
if (layoutRef.value) {
|
|
// Reset scroll position
|
|
if (layoutRef.value.$refs.listWrapperRef) {
|
|
layoutRef.value.$refs.listWrapperRef.scrollTop = 0;
|
|
}
|
|
|
|
// Reset pagination
|
|
if (layoutRef.value.currentPage !== 1) {
|
|
layoutRef.value.setCurrentPage(1);
|
|
}
|
|
}
|
|
|
|
allVariables.value.unshift(temporaryVariable);
|
|
editMode.value[temporaryVariable.id] = true;
|
|
|
|
telemetry.track('User clicked add variable button');
|
|
}
|
|
|
|
async function saveVariable(data: EnvironmentVariable | TemporaryEnvironmentVariable) {
|
|
let updatedVariable: EnvironmentVariable;
|
|
|
|
try {
|
|
if (typeof data.id === 'string' && data.id.startsWith(TEMPORARY_VARIABLE_UID_BASE)) {
|
|
const { id, ...rest } = data;
|
|
updatedVariable = await environmentsStore.createVariable(rest);
|
|
allVariables.value.unshift(updatedVariable);
|
|
allVariables.value = allVariables.value.filter((variable) => variable.id !== data.id);
|
|
newlyAddedVariableIds.value.unshift(updatedVariable.id);
|
|
} else {
|
|
updatedVariable = await environmentsStore.updateVariable(data as EnvironmentVariable);
|
|
allVariables.value = allVariables.value.filter((variable) => variable.id !== data.id);
|
|
allVariables.value.push(updatedVariable);
|
|
toggleEditing(updatedVariable);
|
|
}
|
|
} catch (error) {
|
|
showError(error, i18n.baseText('variables.errors.save'));
|
|
}
|
|
}
|
|
|
|
function toggleEditing(data: EnvironmentVariable) {
|
|
editMode.value = {
|
|
...editMode.value,
|
|
[data.id]: !editMode.value[data.id],
|
|
};
|
|
}
|
|
|
|
function cancelEditing(data: EnvironmentVariable | TemporaryEnvironmentVariable) {
|
|
if (typeof data.id === 'string' && data.id.startsWith(TEMPORARY_VARIABLE_UID_BASE)) {
|
|
allVariables.value = allVariables.value.filter((variable) => variable.id !== data.id);
|
|
} else {
|
|
toggleEditing(data as EnvironmentVariable);
|
|
}
|
|
}
|
|
|
|
async function deleteVariable(data: EnvironmentVariable) {
|
|
try {
|
|
await message.confirm(
|
|
i18n.baseText('variables.modals.deleteConfirm.message', { interpolate: { name: data.key } }),
|
|
i18n.baseText('variables.modals.deleteConfirm.title'),
|
|
{
|
|
confirmButtonText: i18n.baseText('variables.modals.deleteConfirm.confirmButton'),
|
|
cancelButtonText: i18n.baseText('variables.modals.deleteConfirm.cancelButton'),
|
|
},
|
|
);
|
|
} catch (e) {
|
|
return;
|
|
}
|
|
|
|
try {
|
|
await environmentsStore.deleteVariable(data);
|
|
allVariables.value = allVariables.value.filter((variable) => variable.id !== data.id);
|
|
} catch (error) {
|
|
showError(error, i18n.baseText('variables.errors.delete'));
|
|
}
|
|
}
|
|
|
|
function goToUpgrade() {
|
|
uiStore.goToUpgrade('variables', 'upgrade-variables');
|
|
}
|
|
|
|
function displayName(resource: EnvironmentVariable) {
|
|
return resource.key;
|
|
}
|
|
|
|
onBeforeMount(() => {
|
|
sourceControlStoreUnsubscribe = sourceControlStore.$onAction(({ name, after }) => {
|
|
if (name === 'pullWorkfolder' && after) {
|
|
after(() => {
|
|
void initialize();
|
|
});
|
|
}
|
|
});
|
|
});
|
|
|
|
onBeforeUnmount(() => {
|
|
sourceControlStoreUnsubscribe();
|
|
});
|
|
</script>
|
|
|
|
<template>
|
|
<ResourcesListLayout
|
|
class="variables-view"
|
|
ref="layoutRef"
|
|
resource-key="variables"
|
|
:disabled="!isFeatureEnabled"
|
|
:resources="allVariables"
|
|
:initialize="initialize"
|
|
:shareable="false"
|
|
:displayName="displayName"
|
|
:sortFns="sortFns"
|
|
:sortOptions="['nameAsc', 'nameDesc']"
|
|
:showFiltersDropdown="false"
|
|
type="datatable"
|
|
:type-props="{ columns: datatableColumns }"
|
|
@sort="resetNewVariablesList"
|
|
@click:add="addTemporaryVariable"
|
|
>
|
|
<template #add-button>
|
|
<n8n-tooltip placement="top" :disabled="canCreateVariables">
|
|
<div>
|
|
<n8n-button
|
|
size="large"
|
|
block
|
|
:disabled="!canCreateVariables"
|
|
@click="addTemporaryVariable"
|
|
data-test-id="resources-list-add"
|
|
>
|
|
{{ $locale.baseText(`variables.add`) }}
|
|
</n8n-button>
|
|
</div>
|
|
<template #content>
|
|
<span v-if="!isFeatureEnabled">{{
|
|
i18n.baseText(`variables.add.unavailable${allVariables.length === 0 ? '.empty' : ''}`)
|
|
}}</span>
|
|
<span v-else>{{ i18n.baseText('variables.add.onlyOwnerCanCreate') }}</span>
|
|
</template>
|
|
</n8n-tooltip>
|
|
</template>
|
|
<template v-if="!isFeatureEnabled" #preamble>
|
|
<n8n-action-box
|
|
class="mb-m"
|
|
data-test-id="unavailable-resources-list"
|
|
emoji="👋"
|
|
:heading="$locale.baseText(contextBasedTranslationKeys.variables.unavailable.title)"
|
|
:description="
|
|
$locale.baseText(contextBasedTranslationKeys.variables.unavailable.description)
|
|
"
|
|
:buttonText="$locale.baseText(contextBasedTranslationKeys.variables.unavailable.button)"
|
|
buttonType="secondary"
|
|
@click:button="goToUpgrade"
|
|
/>
|
|
</template>
|
|
<template v-if="!isFeatureEnabled || (isFeatureEnabled && !canCreateVariables)" #empty>
|
|
<n8n-action-box
|
|
v-if="!isFeatureEnabled"
|
|
data-test-id="unavailable-resources-list"
|
|
emoji="👋"
|
|
:heading="$locale.baseText(contextBasedTranslationKeys.variables.unavailable.title)"
|
|
:description="
|
|
$locale.baseText(contextBasedTranslationKeys.variables.unavailable.description)
|
|
"
|
|
:buttonText="$locale.baseText(contextBasedTranslationKeys.variables.unavailable.button)"
|
|
buttonType="secondary"
|
|
@click:button="goToUpgrade"
|
|
/>
|
|
<n8n-action-box
|
|
v-else-if="!canCreateVariables"
|
|
data-test-id="cannot-create-variables"
|
|
emoji="👋"
|
|
:heading="
|
|
$locale.baseText('variables.empty.notAllowedToCreate.heading', {
|
|
interpolate: { name: usersStore.currentUser.firstName },
|
|
})
|
|
"
|
|
:description="$locale.baseText('variables.empty.notAllowedToCreate.description')"
|
|
@click="goToUpgrade"
|
|
/>
|
|
</template>
|
|
<template #default="{ data }">
|
|
<VariablesRow
|
|
:key="data.id"
|
|
:editing="editMode[data.id]"
|
|
:data="data"
|
|
@save="saveVariable"
|
|
@edit="toggleEditing"
|
|
@cancel="cancelEditing"
|
|
@delete="deleteVariable"
|
|
/>
|
|
</template>
|
|
</ResourcesListLayout>
|
|
</template>
|
|
|
|
<style lang="scss" module>
|
|
.type-input {
|
|
--max-width: 265px;
|
|
}
|
|
|
|
.sidebarContainer ul {
|
|
padding: 0 !important;
|
|
}
|
|
</style>
|
|
|
|
<style lang="scss" scoped>
|
|
@use 'n8n-design-system/css/common/var.scss';
|
|
|
|
.variables-view {
|
|
:deep(.datatable) {
|
|
table {
|
|
table-layout: fixed;
|
|
}
|
|
|
|
th,
|
|
td {
|
|
width: 25%;
|
|
|
|
@media screen and (max-width: var.$md) {
|
|
width: 33.33%;
|
|
}
|
|
|
|
&.variables-value-column,
|
|
&.variables-key-column,
|
|
&.variables-usage-column {
|
|
> div {
|
|
width: 100%;
|
|
|
|
> span {
|
|
max-width: 100%;
|
|
overflow: hidden;
|
|
text-overflow: ellipsis;
|
|
white-space: nowrap;
|
|
height: 18px;
|
|
}
|
|
|
|
> div {
|
|
width: 100%;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
.variables-usage-column {
|
|
@media screen and (max-width: var.$md) {
|
|
display: none;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
</style>
|