release v19.1.0

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ag-grid-react-example",
-  "version": "21.0.0",
+  "version": "19.1.0",
   "description": "Example Reach applicaiton using ag-Grid.",
   "main": "dist/ag-grid-react-example.js",
   "scripts": {
@@ -17,8 +17,7 @@
     "build-dashboard": "webpack --config config/webpack.config.trader.js --progress --profile --bail",
     "build-all": "npm run build-examples && npm run build-dashboard",
     "build": "npm run clean && npm run mkdirs && npm run build-all && npm run copy",
-    "start": "npm run examples",
+    "start": "npm run examples"
-    "test": "./ts-tests/runTsTests.sh"
   },
   "repository": {
     "type": "git",
@@ -38,39 +37,36 @@
   },
   "homepage": "http://www.ag-grid.com/",
   "devDependencies": {
-    "@babel/core": "7.4.4",
+    "@babel/core": "7.1.2",
-    "@babel/plugin-proposal-class-properties": "7.4.4",
+    "babel-loader": "8.0.4",
-    "@babel/plugin-proposal-function-bind": "7.2.0",
+    "@babel/preset-env": "7.1.0",
-    "@babel/preset-env": "7.4.4",
     "@babel/preset-react": "7.0.0",
-    "@types/react": "16.8.17",
+    "@babel/plugin-proposal-class-properties": "7.1.0",
-    "@types/react-dom": "16.8.4",
+    "@babel/plugin-proposal-function-bind": "7.0.0",
-    "babel-loader": "8.0.6",
+    "css-loader": "1.0.0",
-    "css-loader": "2.1.1",
+    "file-loader": "2.0.0",
-    "file-loader": "3.0.1",
     "gulp": "3.9.1",
-    "merge2": "1.2.3",
+    "merge2": "^1.2.3",
     "mkdirp": "0.5.1",
     "ncp": "2.0.0",
-    "prop-types": "15.7.2",
+    "prop-types": "15.6.2",
-    "rimraf": "2.6.3",
+    "rimraf": "~2.6.2",
-    "style-loader": "0.23.1",
+    "style-loader": "~0.23.0",
-    "typescript": "3.4.5",
+    "webpack": "^4.16.1",
-    "webpack": "4.31.0",
+    "webpack-cli": "^3.0.8",
-    "webpack-cli": "3.3.2",
+    "webpack-dev-server": "^3.1.4"
-    "webpack-dev-server": "3.4.1"
   },
   "dependencies": {
-    "ag-grid-community": "^21.0.0",
+    "ag-grid-community": "^19.1.0",
-    "ag-grid-enterprise": "^21.0.0",
+    "ag-grid-enterprise": "^19.1.0",
-    "ag-grid-react": "^21.0.0",
+    "ag-grid-react": "^19.1.0",
-    "bootstrap": "4.3.1",
+    "bootstrap": "4.1.3",
     "d3": "4.9.1",
-    "lodash": "4.17.11",
+    "lodash": "^4.17.11",
-    "react": "16.8.6",
+    "react": "^16.5.2",
-    "react-dom": "16.8.6",
+    "react-dom": "^16.5.2",
-    "react-redux": "7.0.3",
+    "react-redux": "5.0.7",
-    "react-router-dom": "5.0.0",
+    "react-router-dom": "4.3.1",
-    "redux": "4.0.1"
+    "redux": "^4.0.1"
   }
 }

src-examples/App.jsx

@@ -5,14 +5,12 @@ import NavItem from "./NavItem";
 
 import RichGridDeclarativeExample from "./richGridDeclarativeExample/RichGridDeclarativeExample";
 import SimpleReduxDynamicExample from "./simpleReduxDynamicComponentExample/SimpleReduxExample";
-import SimpleReduxHookExample from "./simpleReduxHooksExample/SimpleReduxHookExample";
 
 const SideBar = () => (
     <div style={{float: "left", width: 335, marginRight: 25}}>
         <ul className="nav nav-pills">
             <NavItem to='/rich-grid-declarative'>Rich Grid with Declarative Markup</NavItem>
             <NavItem to='/simple-redux-dynamic'>Simple Redux Dynamic Component Example</NavItem>
-            <NavItem to='/simple-redux-hook'>Simple React Hook Component Example</NavItem>
         </ul>
     </div>
 );
@@ -27,7 +25,6 @@ class App extends Component {
                         <Redirect from="/" exact to="/rich-grid-declarative"/>
                         <Route exact path='/rich-grid-declarative' component={RichGridDeclarativeExample}/>
                         <Route exact path='/simple-redux-dynamic' component={SimpleReduxDynamicExample}/>
-                        <Route exact path='/simple-redux-hook' component={SimpleReduxHookExample}/>
                     </Switch>
                 </div>
             </div>

src-examples/richGridDeclarativeExample/DateComponent.jsx

@@ -51,11 +51,11 @@ export default class DateComponent extends React.Component {
         return (
             <div style={filterStyle}>
                 <span style={resetStyle} onClick={this.resetDate.bind(this)}>x</span>
-                <input onChange={this.onDateChanged.bind(this)} ref="dd" placeholder="dd" style={ddStyle}
+                <input onInput={this.onDateChanged.bind(this)} ref="dd" placeholder="dd" style={ddStyle}
                        value={this.state.textBoxes.dd} maxLength="2"/>/
-                <input onChange={this.onDateChanged.bind(this)} ref="mm" placeholder="mm" style={mmStyle}
+                <input onInput={this.onDateChanged.bind(this)} ref="mm" placeholder="mm" style={mmStyle}
                        value={this.state.textBoxes.mm} maxLength="2"/>/
-                <input onChange={this.onDateChanged.bind(this)} ref="yyyy" placeholder="yyyy" style={yyyyStyle}
+                <input onInput={this.onDateChanged.bind(this)} ref="yyyy" placeholder="yyyy" style={yyyyStyle}
                        value={this.state.textBoxes.yyyy} maxLength="4"/>
             </div>
         );

src-examples/richGridDeclarativeExample/RichGridDeclarativeExample.jsx

@@ -16,14 +16,14 @@ import "./RichGridDeclarativeExample.css";
 import "ag-grid-enterprise";
 
 export default class RichGridDeclarativeExample extends Component {
-    constructor(props) {
+
-        super(props);
+    constructor() {
+        super();
 
         this.state = {
             quickFilterText: null,
             sideBar: false,
             rowData: new RowDataFactory().createRowData(),
-            rowCount: null,
             icons: {
                 columnRemoveFromGroup: '<i class="fa fa-remove"/>',
                 filter: '<i class="fa fa-filter"/>',
@@ -39,8 +39,6 @@ export default class RichGridDeclarativeExample extends Component {
     onGridReady = (params) => {
         this.api = params.api;
         this.columnApi = params.columnApi;
-
-        this.calculateRowCount();
     };
 
     onCellClicked = (event) => {
@@ -88,18 +86,7 @@ export default class RichGridDeclarativeExample extends Component {
         // simply wait for the next tick
         setTimeout(() => {
             this.api.onFilterChanged();
-        });
+        }, 0)
-    };
-
-    calculateRowCount = () => {
-        if (this.api && this.state.rowData) {
-            const model = this.api.getModel();
-            const totalRows = this.state.rowData.length;
-            const processedRows = model.getRowCount();
-            this.setState({
-                rowCount: processedRows.toLocaleString() + ' / ' + totalRows.toLocaleString()
-            });
-        }
     };
 
     static countryCellRenderer(params) {
@@ -128,7 +115,7 @@ export default class RichGridDeclarativeExample extends Component {
                 <h1>Rich Grid with Declarative Markup Example</h1>
                 <div style={{display: "inline-block", width: "100%"}}>
                     <div style={{float: "left"}}>
-                        <b>Employees Skills and Contact Details: </b>{ this.state.rowCount }
+                        <b>Employees Skills and Contact Details</b><span id="rowCount"/>
                     </div>
                 </div>
                 <div style={{marginTop: 10}}>
@@ -154,34 +141,32 @@ export default class RichGridDeclarativeExample extends Component {
                     </div>
                     <div style={{display: "inline-block", width: "100%", marginTop: 10, marginBottom: 10}}>
                         <div style={{float: "left"}}>
+                            <label>
+                                <input type="checkbox" onChange={this.onToggleSidebar} style={{marginRight: 5}}/>
+                                Show Side Bar
+                            </label>
+                        </div>
+                        <div style={{float: "left", marginLeft: 20}}>
                             <button onClick={this.onRefreshData} className="btn btn-primary">Refresh Data</button>
                         </div>
+                        <div style={{float: "left", marginLeft: 20}}>
+                            <input type="text" onChange={this.onQuickFilterText} placeholder="Type text to filter..."/>
+                        </div>
                         <div style={{float: "right"}}>
                             Filter API:
                             <button onClick={this.invokeSkillsFilterMethod}
                                     className="btn btn-primary">Invoke Skills Filter Method
                             </button>
-                            <button onClick={this.dobFilter} className="btn btn-primary">DOB equals to 01/01/2000
+                            <button onClick={this.dobFilter} className="btn btn-primary">DOB equals to 01/01/2000ß
                             </button>
                         </div>
                     </div>
-                    <div style={{display: "inline-block", width: "100%", marginTop: 10, marginBottom: 10}}>
-                        <div style={{float: "left"}}>
-                            <label htmlFor="sideBarToggle">Show Side Bar&nbsp;</label>
-                            <input type="checkbox" id="sideBarToggle" onChange={this.onToggleSidebar} style={{marginRight: 5}}/>
-                        </div>
-                        <div style={{float: "right", marginLeft: 20}}>
-                            <label htmlFor="quickFilter">Quick Filter:&nbsp;</label>
-                            <input type="text" id="quickFilter" onChange={this.onQuickFilterText} placeholder="Type text to filter..."/>
-                        </div>
-                    </div>
                     <div style={{height: 400, width: 900}} className="ag-theme-balham">
                         <AgGridReact
                             // listening for events
                             onGridReady={this.onGridReady}
                             onRowSelected={this.onRowSelected}
                             onCellClicked={this.onCellClicked}
-                            onModelUpdated={this.calculateRowCount}
 
                             // binding to simple properties
                             sideBar={this.state.sideBar}
@@ -194,9 +179,13 @@ export default class RichGridDeclarativeExample extends Component {
                             rowData={this.state.rowData}
 
                             // no binding, just providing hard coded strings for the properties
-                            // boolean properties will default to true if provided (ie suppressRowClickSelection => suppressRowClickSelection="true")
+                            // boolean properties will default to true if provided (ie enableColResize => enableColResize="true")
                             suppressRowClickSelection
                             rowSelection="multiple"
+                            enableColResize
+                            enableSorting
+                            enableFilter
+                            floatingFilter
                             groupHeaders
 
                             // setting grid wide date component
@@ -204,16 +193,14 @@ export default class RichGridDeclarativeExample extends Component {
 
                             // setting default column properties
                             defaultColDef={{
-                                resizable: true,
-                                sortable: true,
-                                filter: true,
                                 headerComponentFramework: SortableHeaderComponent,
                                 headerComponentParams: {
                                     menuIcon: 'fa-bars'
                                 }
-                            }}>
+                            }}
+                        >
                             <AgGridColumn headerName="#" width={30}
-                                          checkboxSelection sortable={false} suppressMenu filter={false} pinned>
+                                          checkboxSelection suppressSorting suppressMenu suppressFilter pinned>
                             </AgGridColumn>
                             <AgGridColumn headerName="Employee" headerGroupComponentFramework={HeaderGroupComponent}>
                                 <AgGridColumn field="name" width={150}
@@ -231,10 +218,10 @@ export default class RichGridDeclarativeExample extends Component {
                                               cellRenderer={RichGridDeclarativeExample.dateCellRenderer}/>
                             </AgGridColumn>
                             <AgGridColumn headerName="IT Skills">
-                                <AgGridColumn field="skills" width={120} enableRowGroup enablePivot sortable={false}
+                                <AgGridColumn field="skills" width={120} enableRowGroup enablePivot suppressSorting
                                               cellRendererFramework={SkillsCellRenderer}
                                               filterFramework={SkillsFilter}/>
-                                <AgGridColumn field="proficiency" width={160} enableValue
+                                <AgGridColumn field="proficiency" width={135} enableValue
                                               cellRendererFramework={ProficiencyCellRenderer}
                                               filterFramework={ProficiencyFilter}/>
                             </AgGridColumn>
@@ -245,6 +232,130 @@ export default class RichGridDeclarativeExample extends Component {
                             </AgGridColumn>
                         </AgGridReact>
                     </div>
+                    <div style={{marginTop: 10}}>
+                        <div className="row">
+                            <div className="col-sm-12"><h1>Rich Grid with Declarative Markup Example</h1></div>
+                        </div>
+                        <div className="row">
+                            <div className="col-sm-12">
+                                <h5>This example demonstrates many features of ag-Grid, with Grid and Column Definition
+                                    defined declaratively (i.e. with markup).</h5>
+                                <p><span style={{fontWeight: 500}}>Select All/Clear Selection</span>: Select or Deselect
+                                    All
+                                    Rows</p>
+                                <p><span style={{fontWeight: 500}}>Hide/Show Country Column</span>: Select or Deselect
+                                    All
+                                    Rows
+                                    (expand the Employee column to show the Country column first)</p>
+                                <p><span style={{fontWeight: 500}}>Toggle The Side Bar</span>: Let your users Pivot,
+                                    Group
+                                    and
+                                    Aggregate using the Side Bar</p>
+                                <p><span style={{fontWeight: 500}}>Refresh Data</span>: Dynamically Update Grid Data</p>
+                                <p><span style={{fontWeight: 500}}>Quick Filter</span>: Perform Quick Grid Wide
+                                    Filtering
+                                    with
+                                    the Quick Filter</p>
+                                <p><span style={{fontWeight: 500}}>DOB Filter</span>: Set the DOB filter to 01/01/2000
+                                    using
+                                    the
+                                    Filter API (expand the Employee column to show the DOB column)</p>
+                                <p><span style={{fontWeight: 500}}>Custom Headers</span>: Sort, Filter and Render
+                                    Headers
+                                    using
+                                    Header Components</p>
+                            </div>
+                        </div>
+                        <div className="row">
+                            <div className="col-sm-4">
+                                <div className="card">
+                                    <div className="card-body">
+                                        <h4 className="card-title">Grid & Column API</h4>
+                                        <p className="card-text">Utilise Grid Features Programmatically Using the APIs
+                                            Available</p>
+                                        <a target="_blank" href="https://www.ag-grid.com/javascript-grid-api/"
+                                           className="btn btn-primary">Grid API</a>
+                                        <a target="_blank" href="https://www.ag-grid.com//javascript-grid-column-api/"
+                                           className="btn btn-primary">Column API</a>
+                                    </div>
+                                </div>
+                            </div>
+                            <div className="col-sm-4">
+                                <div className="card">
+                                    <div className="card-body">
+                                        <h4 className="card-title">Header Components</h4>
+                                        <p className="card-text">Customer the Header with React Components</p>
+                                        <a target="_blank"
+                                           href="https://www.ag-grid.com//javascript-grid-header-rendering/#headerComponent"
+                                           className="btn btn-primary">Header Component</a>
+                                        <a target="_blank"
+                                           href="https://www.ag-grid.com//javascript-grid-header-rendering/#headerGroupComponent"
+                                           className="btn btn-primary">Header Group Component</a>
+                                    </div>
+                                </div>
+                            </div>
+                            <div className="col-sm-4">
+                                <div className="card">
+                                    <div className="card-body">
+                                        <h4 className="card-title">Filters</h4>
+                                        <p className="card-text">Filter with Quick Filters, Floating Filters, Built In
+                                            Filters
+                                            or Using the
+                                            Filter API</p>
+                                        <a target="_blank" href="https://www.ag-grid.com//javascript-grid-filter-quick/"
+                                           className="btn btn-primary">Quick
+                                            Filter</a>
+                                        <a target="_blank"
+                                           href="https://www.ag-grid.com//javascript-grid-floating-filter-component/"
+                                           className="btn btn-primary">Floating Filters</a>
+                                        <a target="_blank" href="https://www.ag-grid.com//javascript-grid-filtering/"
+                                           className="btn btn-primary">Built in
+                                            Filters</a>
+                                        <a target="_blank"
+                                           href="https://www.ag-grid.com//javascript-grid-filtering/#accessing-filter-component-instances"
+                                           className="btn btn-primary">Filter API</a>
+                                    </div>
+                                </div>
+                            </div>
+                        </div>
+                        <div className="row">
+                            <div className="col-sm-4">
+                                <div className="card">
+                                    <div className="card-body">
+                                        <h4 className="card-title">Side Bar</h4>
+                                        <p className="card-text">Let your users Pivot, Group and Aggregate using the
+                                            Side Bar</p>
+                                        <a target="_blank" href="https://www.ag-grid.com//javascript-grid-side-bar/"
+                                           className="btn btn-primary">Side Bar</a>
+                                    </div>
+                                </div>
+                            </div>
+                            <div className="col-sm-8">
+                                <div className="card">
+                                    <div className="card-body">
+                                        <h4 className="card-title">The Rest</h4>
+                                        <p className="card-text">Pinned Columns, Checkbox Selection, Customer Renderers,
+                                            Data
+                                            Updates</p>
+                                        <a target="_blank"
+                                           href="https://www.ag-grid.com/best-react-data-grid/?framework=react"
+                                           className="btn btn-primary">React with ag-Grid</a>
+                                        <a target="_blank" href="https://www.ag-grid.com//javascript-grid-pinning/"
+                                           className="btn btn-primary">Pinned Column</a>
+                                        <a target="_blank"
+                                           href="https://www.ag-grid.com//javascript-grid-selection/#checkboxSelection"
+                                           className="btn btn-primary">Checkbox Selection</a>
+                                        <a target="_blank"
+                                           href="https://www.ag-grid.com//javascript-grid-cell-rendering/"
+                                           className="btn btn-primary">Cell
+                                            Renderers</a>
+                                        <a target="_blank" href="https://www.ag-grid.com/javascript-grid-data-update/"
+                                           className="btn btn-primary">Updating Data</a>
+                                    </div>
+                                </div>
+                            </div>
+                        </div>
+                    </div>
                 </div>
             </div>
         );

src-examples/richGridDeclarativeExample/SkillsFilter.jsx

@@ -56,7 +56,7 @@ export default class SkillsFilter extends React.Component {
         return passed;
     };
 
-    getModelAsString() {
+    getModel() {
         return ''
     }
 
@@ -83,6 +83,7 @@ export default class SkillsFilter extends React.Component {
 
         const skillsTemplates = [];
         RefData.IT_SKILLS.forEach((skill, index) => {
+
             const skillName = RefData.IT_SKILLS_NAMES[index];
             const template = (
                 <label key={skill}

src-examples/simpleReduxDynamicComponentExample/GridComponent.jsx

@@ -1,10 +1,13 @@
 import React, {Component} from "react";
-import {connect} from "react-redux";
+import * as PropTypes from "prop-types";
 
 import {AgGridReact} from "ag-grid-react";
+import {connect} from "react-redux";
 
 import PriceRenderer from "./PriceRenderer";
 
+const ThemeContext = React.createContext('light');
+
 /*
  * This component serves to display the row data (provided by redux)
  */
@@ -46,6 +49,7 @@ class GridComponent extends Component {
                     rowData={this.props.rowData}
 
                     reactNext={true}
+                    reduxStore={this.context.store} // must be supplied when using redux with reactNext
 
                     // events
                     onGridReady={this.onGridReady}>
@@ -55,6 +59,10 @@ class GridComponent extends Component {
     }
 }
 
+GridComponent.contextTypes = {
+    store: PropTypes.object                         // must be supplied when using redux with reactNext
+};
+
 // pull off row data changes
 export default connect(
     (state) => {

src-examples/simpleReduxDynamicComponentExample/HeaderComponent.jsx

@@ -25,8 +25,8 @@ class HeaderComponent extends Component {
     render() {
         return (
             <div style={{marginTop: 15}}>
-                <button onClick={this.setCurrency.bind(this, '£', 1)} className="btn btn-primary">Set Currency to GBP</button>
+                <button onClick={this.setCurrency.bind(this, '£', 1)}>Set Currency to GBP</button>
-                <button onClick={this.setCurrency.bind(this, '$', 1.29)} className="btn btn-primary">Set Currency to USD</button>
+                <button onClick={this.setCurrency.bind(this, '$', 1.29)}>Set Currency to USD</button>
             </div>
         )
     }
@@ -82,4 +82,4 @@ export default connect(
             rowData: state.rowData
         }
     }
-)(HeaderComponent);
+)(HeaderComponent);

src-examples/simpleReduxDynamicComponentExample/PriceRenderer.jsx

@@ -21,8 +21,7 @@ class PriceRenderer extends Component {
     render() {
         return (
             <FontContext.Consumer>
-                {fontWeight => <span
+                {fontWeight => <span style={{fontWeight}}> {this.props.currencySymbol}{this.state.convertedValue}</span> }
-                    style={{fontWeight}}> {this.props.currencySymbol}{this.state.convertedValue}</span>}
             </FontContext.Consumer>
         );
     }
@@ -41,5 +40,5 @@ export default connect(
     },
     null,
     null,
-    {forwardRef: true} // must be supplied for react/redux when using GridOptions.reactNext
+    {withRef: true} // must be supplied for react/redux when using GridOptions.reactNext
 )(PriceRenderer);

src-examples/simpleReduxHooksExample/GridComponent.jsx

@@ -1,32 +0,0 @@
-import React, { useContext } from "react";
-import {Context} from "./store";
-import {AgGridReact} from "ag-grid-react";
-
-/*
- * This component serves to display the row data (provided by redux)
- */
-export default function GridComponent() {
-    const {store, dispatch} = useContext(Context);
-    const {columnDefs, rowData} = store;
-
-    const onGridReady = (params) => {
-        params.api.sizeColumnsToFit();
-    };
-
-    // row data will be provided via redux on this.props.rowData
-    return (
-        <div style={{height: 400, width: 900, marginTop: 15}}
-             className="ag-theme-balham">
-            <AgGridReact
-                // properties
-                columnDefs={columnDefs}
-                rowData={rowData}
-
-                reactNext={true}
-
-                // events
-                onGridReady={onGridReady}>
-            </AgGridReact>
-        </div>
-    )
-}

src-examples/simpleReduxHooksExample/PriceRenderer.jsx

@@ -1,13 +0,0 @@
-import React, {Component} from "react";
-
-export default class PriceRenderer extends Component {
-    constructor(props) {
-        super(props);
-    }
-
-    render() {
-        return (
-            <span>{this.props.value}</span>
-        );
-    }
-}

src-examples/simpleReduxHooksExample/SimpleReduxHookExample.jsx

@@ -1,18 +0,0 @@
-import React, {useReducer} from "react";
-import GridComponent from "./GridComponent";
-
-import {Context, initialState, reducer} from "./store";
-
-export default function SimpleReduxHookExample() {
-    const [store, dispatch] = useReducer(reducer, initialState);
-
-    return (
-        <Context.Provider value={{store, dispatch}}>
-            <div>
-                <h1>Simple Example using Hooks (with useContext and useReducer)</h1>
-                <button onClick={() => dispatch({type: "SET_ROW_DATA"})} className="btn btn-primary">Populate Row Data</button>
-                <GridComponent/>
-            </div>
-        </Context.Provider>
-    )
-}

src-examples/simpleReduxHooksExample/gridDataActions.jsx

@@ -1,14 +0,0 @@
-export function updateRowData(rowData) {
-    return {
-        type: 'ROW_DATA_CHANGED',
-        rowData
-    }
-}
-
-export function setCurrency(currencySymbol, exchangeRate) {
-    return {
-        type: 'CURRENCY_CHANGED',
-        currencySymbol,
-        exchangeRate
-    }
-}

src-examples/simpleReduxHooksExample/store.js

@@ -1,75 +0,0 @@
-import React from "react";
-import PriceRenderer from "./PriceRenderer";
-
-export const initialState = {
-    rowData: [],
-    columnDefs: [
-        {
-            field: 'symbol'
-        },
-        {
-            field: 'price',
-            cellClass: 'align-right',
-            cellRendererFramework: PriceRenderer
-        }
-    ]
-};
-
-export const reducer = (state = {rowData: []}, action) => {
-    switch (action.type) {
-        case 'SET_ROW_DATA':
-            return {
-                ...state,
-                rowData: createRowData()
-            };
-        default:
-            return state;
-    }
-};
-
-export const Context = React.createContext();
-
-
-// for test data
-// the following methods are for creating dummy row data
-const createRowData = () => {
-    let rowData = [];
-
-    for (let i = 0; i < 14; i++) {
-        let newItem = createItem(rowData);
-        rowData.push(newItem);
-    }
-
-    return rowData;
-};
-
-const createItem = (rowData) => {
-    return {
-        symbol: createUniqueRandomSymbol(rowData),
-        price: Math.floor(Math.random() * 100)
-    };
-};
-
-// creates a unique symbol, eg 'ADG' or 'ZJD'
-const createUniqueRandomSymbol = (rowData) => {
-    let symbol;
-    let possible = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
-
-    let isUnique = false;
-    while (!isUnique) {
-        symbol = '';
-        // create symbol
-        for (let i = 0; i < 3; i++) {
-            symbol += possible.charAt(Math.floor(Math.random() * possible.length));
-        }
-        // check uniqueness
-        isUnique = true;
-        rowData.forEach(function (oldItem) {
-            if (oldItem.symbol === symbol) {
-                isUnique = false;
-            }
-        });
-    }
-
-    return symbol;
-};

src-trader-dashboard/components/FxQuoteMatrix.jsx

@@ -32,28 +32,26 @@ class FxQuoteMatrix extends Component {
     }
 
     componentWillReceiveProps(nextProps) {
-        if (this.gridApi) {
+        const newRowData = nextProps.rowData;
-            const newRowData = nextProps.rowData;
 
-            const updatedRows = [];
+        const updatedRows = [];
 
-            for (let i = 0; i < newRowData.length; i++) {
+        for (let i = 0; i < newRowData.length; i++) {
-                let newRow = newRowData[i];
+            let newRow = newRowData[i];
-                let currentRowNode = this.gridApi.getRowNode(newRow.symbol);
+            let currentRowNode = this.gridApi.getRowNode(newRow.symbol);
 
-                const {data} = currentRowNode;
+            const {data} = currentRowNode;
-                for (const def of this.state.columnDefs) {
+            for (const def of this.state.columnDefs) {
-                    if (data[def.field] !== newRow[def.field]) {
+                if (data[def.field] !== newRow[def.field]) {
-                        updatedRows.push(newRow);
+                    updatedRows.push(newRow);
-                        break;
+                    break;
-                    }
                 }
             }
-
-
-            this.gridApi.updateRowData({update: updatedRows});
         }
 
+
+        this.gridApi.updateRowData({update: updatedRows});
+
     }
 
     render() {
@@ -63,10 +61,8 @@ class FxQuoteMatrix extends Component {
                 <AgGridReact
                     // properties
                     columnDefs={this.state.columnDefs}
-                    defaultColDef={{
+                    enableSorting="false"
-                        sortable: false,
+                    enableFilter="false"
-                        filter: false
-                    }}
 
                     // callbacks
                     getRowNodeId={this.getRowNodeId}
@@ -82,7 +78,7 @@ class FxQuoteMatrix extends Component {
 export default connect(
     (state) => {
         return {
-            rowData: state ? state.fxData : null
+            rowData: state.fxData
         }
     }
 )(FxQuoteMatrix);

src-trader-dashboard/components/PriceChangesGrid.jsx

@@ -155,9 +155,7 @@ export default class extends Component {
                 <AgGridReact
                     // properties
                     columnDefs={this.state.columnDefs}
-                    defaultColDef={{
+                    enableSorting="true"
-                        sortable: true
-                    }}
                     rowSelection="single"
 
                     // callbacks

src-trader-dashboard/components/TopMoversGrid.jsx

@@ -67,10 +67,8 @@ class TopMoversGrid extends Component {
                     // properties
                     columnDefs={this.state.columnDefs}
                     rowData={this.props.rowData}
-                    defaultColDef={{
+                    enableSorting
-                        sortable: true,
+                    enableFilter="false"
-                        filter: false
-                    }}
                     animateRows
                     deltaRowDataMode
                     getRowNodeId={this.getRowNodeId}
@@ -86,7 +84,7 @@ class TopMoversGrid extends Component {
 export default connect(
     (state) => {
         return {
-            rowData: state ? state.fxTopMovers : null
+            rowData: state.fxTopMovers
         }
     }
-)(TopMoversGrid);
+)(TopMoversGrid);

ts-tests/InvalidGridProperty.tsx

@@ -1,4 +0,0 @@
-import React from 'react';
-import {AgGridReact} from 'ag-grid-react';
-
-export const App: React.FunctionComponent = () => <AgGridReact invalidProperty columnDefs={[]} rowData={[]}/>;

ts-tests/SimpleFunctionalGrid.tsx

@@ -1,4 +0,0 @@
-import React from 'react';
-import {AgGridReact} from 'ag-grid-react';
-
-export const App: React.FunctionComponent = () => <AgGridReact columnDefs={[]} rowData={[]}/>;

ts-tests/runTsTests.sh

@@ -1,26 +0,0 @@
-#!/usr/bin/env bash
-
-# here as a quick ts test for use in the CI
-# in time this will be removed the full battery of tests be moved to a centralised location
-
-error_found=false
-
-# has an invalid property - should complain
-./node_modules/.bin/tsc --target "ES5" --module 'commonjs' --lib esnext,dom --allowSyntheticDefaultImports --jsx 'preserve' --noEmit --strict ts-tests/InvalidGridProperty.tsx &> /dev/null
-if [ $? -ne 1 ]; then
-    echo "ag-grid-react grid with invalid property should throw a compiler error"
-    error_found=true
-fi
-
-# a valid grid - no errors should be emitted
-./node_modules/.bin/tsc --target "ES5" --module 'commonjs' --lib esnext,dom --allowSyntheticDefaultImports --jsx 'preserve' --noEmit --strict ts-tests/SimpleFunctionalGrid.tsx &> /dev/null
-if [ $? -ne 0 ]; then
-    echo "valid ag-grid-react grid should compile"
-    error_found=true
-fi
-
-if [ "$error_found" = true ]; then
-    exit 1
-fi
-
-exit 0