Merge branch 'b23.0.2' into latest

.gitignore

@@ -1,3 +1,4 @@
 /node_modules
 /dist
 package-lock.json
+*.nosync

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ag-grid-react-example",
-  "version": "22.0.0",
+  "version": "23.0.2",
   "description": "Example Reach applicaiton using ag-Grid.",
   "main": "dist/ag-grid-react-example.js",
   "scripts": {
@@ -38,7 +38,7 @@
   },
   "homepage": "http://www.ag-grid.com/",
   "devDependencies": {
-    "@ag-grid-community/core": "~22.0.0",
+    "@ag-grid-community/core": "~23.0.0",
     "@babel/core": "7.4.4",
     "@babel/plugin-proposal-class-properties": "7.4.4",
     "@babel/plugin-proposal-function-bind": "7.2.0",
@@ -62,9 +62,9 @@
     "webpack-dev-server": "3.4.1"
   },
   "dependencies": {
-    "@ag-grid-enterprise/all-modules": "~22.0.0",
+    "@ag-grid-enterprise/all-modules": "~23.0.0",
-    "@ag-grid-community/react": "~22.0.0",
+    "@ag-grid-community/react": "~23.0.0",
-    "bootstrap": "4.3.1",
+    "bootstrap": "4.4.1",
     "d3": "4.9.1",
     "lodash": "4.17.11",
     "react": "16.8.6",

src-examples/richGridDeclarativeExample/RichGridDeclarativeExample.jsx

@@ -29,7 +29,7 @@ export default class RichGridDeclarativeExample extends Component {
             rowData: new RowDataFactory().createRowData(),
             rowCount: null,
             icons: {
-                columnRemoveFromGroup: '<i class="fa fa-remove"/>',
+                columnRemoveFromGroup: '<i class="fa fa-times"/>',
                 filter: '<i class="fa fa-filter"/>',
                 sortAscending: '<i class="fa fa-long-arrow-down"/>',
                 sortDescending: '<i class="fa fa-long-arrow-up"/>',
@@ -75,13 +75,14 @@ export default class RichGridDeclarativeExample extends Component {
     };
 
     invokeSkillsFilterMethod = () => {
-        let skillsFilter = this.api.getFilterInstance('skills');
+        this.api.getFilterInstance('skills', (instance) => {
-        let componentInstance = skillsFilter.getFrameworkComponentInstance();
+            let componentInstance = instance.getFrameworkComponentInstance();
             componentInstance.helloFromSkillsFilter();
+        });
     };
 
     dobFilter = () => {
-        let dateFilterComponent = this.api.getFilterInstance('dob');
+        this.api.getFilterInstance('dob', (dateFilterComponent) => {
             dateFilterComponent.setModel({
                 type: 'equals',
                 dateFrom: '2000-01-01'
@@ -93,6 +94,7 @@ export default class RichGridDeclarativeExample extends Component {
             setTimeout(() => {
                 this.api.onFilterChanged();
             });
+        });
     };
 
     calculateRowCount = () => {
@@ -140,19 +142,19 @@ export default class RichGridDeclarativeExample extends Component {
                         <span>
                             Grid API:
                             <button onClick={() => {
-                                this.api.selectAll()
+                                this.api.selectAll();
                             }} className="btn btn-primary">Select All</button>
                             <button onClick={() => {
-                                this.api.deselectAll()
+                                this.api.deselectAll();
                             }} className="btn btn-primary">Clear Selection</button>
                         </span>
                         <span style={{ float: "right" }}>
                             Column API:
                             <button onClick={() => {
-                                this.columnApi.setColumnVisible('country', false)
+                                this.columnApi.setColumnVisible('country', false);
                             }} className="btn btn-primary">Hide Country Column</button>
                             <button onClick={() => {
-                                this.columnApi.setColumnVisible('country', true)
+                                this.columnApi.setColumnVisible('country', true);
                             }} className="btn btn-primary">Show Country Column</button>
                         </span>
                     </div>
@@ -219,7 +221,7 @@ export default class RichGridDeclarativeExample extends Component {
                                     menuIcon: 'fa-bars'
                                 }
                             }}>
-                            <AgGridColumn headerName="#" width={30}
+                            <AgGridColumn headerName="#" width={40}
                                 checkboxSelection sortable={false} suppressMenu filter={false} pinned>
                             </AgGridColumn>
                             <AgGridColumn headerName="Employee" headerGroupComponentFramework={HeaderGroupComponent}>

src-large-data/index.js

@@ -5,7 +5,7 @@ import React from 'react';
 import LargeGrid from './largeGrid.jsx';
 
 import '@ag-grid-community/core/dist/styles/ag-grid.css';
-import '@ag-grid-community/core/dist/styles/ag-theme-fresh.css';
+import '@ag-grid-community/core/dist/styles/ag-theme-balham.css';
 
 // waiting for dom to load before booting react. we could alternatively
 // put the index.js reference at the end fo the index.html, but i prefer this way.

src-large-data/largeGrid.jsx

@@ -63,7 +63,7 @@ export default class MyApp extends Component {
 
     render() {
         return (
-            <div style={{height: '100%'}} className="ag-theme-fresh">
+            <div style={{height: '100%'}} className="ag-theme-balham">
                 <AgGridReact columnDefs={this.state.columnDefs} rowData={this.state.rowData} modules={AllModules}/>
             </div>
         );

src-trader-dashboard/components/FxQuoteMatrix.jsx

@@ -61,7 +61,7 @@ class FxQuoteMatrix extends Component {
     render() {
         return (
             <div style={{height: 410, width: 800}}
-                 className="ag-theme-fresh">
+                 className="ag-theme-balham">
                 <AgGridReact
                     // properties
                     columnDefs={this.state.columnDefs}

src-trader-dashboard/components/PriceChangesGrid.jsx

@@ -152,7 +152,7 @@ export default class extends Component {
     render() {
         return (
             <div style={{height: 410, width: 800}}
-                 className="ag-theme-fresh">
+                 className="ag-theme-balham">
                 <AgGridReact
                     // properties
                     columnDefs={this.state.columnDefs}

src-trader-dashboard/components/TopMoversGrid.jsx

@@ -63,7 +63,7 @@ class TopMoversGrid extends Component {
     render() {
         return (
             <div style={{height: 410, width: 400}}
-                 className="ag-theme-fresh">
+                 className="ag-theme-balham">
                 <AgGridReact
                     // properties
                     columnDefs={this.state.columnDefs}

src-trader-dashboard/index.js

@@ -9,7 +9,7 @@ import StoreService from './services/StoreService';
 import TraderDashboard from "./components/TraderDashboard.jsx";
 
 import "@ag-grid-enterprise/all-modules/dist/styles/ag-grid.css";
-import "@ag-grid-enterprise/all-modules/dist/styles/ag-theme-fresh.css";
+import "@ag-grid-enterprise/all-modules/dist/styles/ag-theme-balham.css";
 
 let store = StoreService.STORE;