From e80f80524adb7804e8bad1b8d34893b843ef4a11 Mon Sep 17 00:00:00 2001
From: Brad Bohen <bbohen@gmail.com>
Date: Wed, 11 Oct 2017 17:05:10 -0400
Subject: [PATCH] feat: Updated replace() to pass id from placeholder element
 (#193)

---
 README.md      | 6 +++---
 src/replace.js | 4 +++-
 src/to-svg.js  | 8 +++++---
 3 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/README.md b/README.md
index 95f6597..d9cd1ee 100644
--- a/README.md
+++ b/README.md
@@ -229,13 +229,13 @@ You can pass `feather.replace()` an `options` object:
 </script>
 ```
 
-All classes on a placeholder element (i.e. `<i>`) will be copied to the `<svg>` tag:
+The id and classes on a placeholder element (i.e. `<i>`) will be copied to the `<svg>` tag:
 
 ```html
-<i class="foo bar" data-feather="circle"></i>
+<i id="my-circle-icon" class="foo bar" data-feather="circle"></i>
 <!--
 <i> will be replaced with:
-<svg class="feather feather-circle foo bar" xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><circle cx="12" cy="12" r="10"></circle></svg>
+<svg id="my-circle-icon" class="feather feather-circle foo bar" xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"><circle cx="12" cy="12" r="10"></circle></svg>
 -->
 
 <script>
diff --git a/src/replace.js b/src/replace.js
index 7c55188..e322b10 100644
--- a/src/replace.js
+++ b/src/replace.js
@@ -42,11 +42,13 @@ function replaceElement(element, options) {
   }
 
   const elementClassAttr = element.getAttribute('class') || '';
+  const elementIdAttr = element.getAttribute('id');
   const classNames = (
     options.class ? `${options.class} ${elementClassAttr}` : elementClassAttr
   );
 
-  const svgString = toSvg(key, Object.assign({}, options, { class: classNames }));
+  const svgOptions = Object.assign({}, options, { class: classNames, id: elementIdAttr });
+  const svgString = toSvg(key, svgOptions);
   const svgDocument = new DOMParser().parseFromString(svgString, 'image/svg+xml');
   const svgElement = svgDocument.querySelector('svg');
 
diff --git a/src/to-svg.js b/src/to-svg.js
index 253cc51..c00a19e 100644
--- a/src/to-svg.js
+++ b/src/to-svg.js
@@ -35,7 +35,7 @@ export default function toSvg(key, options = {}) {
 
   combinedOptions.class = addDefaultClassNames(combinedOptions.class, key);
 
-  const attributes = optionsToAtrributes(combinedOptions);
+  const attributes = optionsToAttributes(combinedOptions);
 
   return `<svg ${attributes}>${icons[key]}</svg>`;
 }
@@ -64,11 +64,13 @@ function addDefaultClassNames(classNames, key) {
  * @param {Object} options
  * @returns {string}
  */
-function optionsToAtrributes(options) {
+function optionsToAttributes(options) {
   const attributes = [];
 
   Object.keys(options).forEach(key => {
-    attributes.push(`${key}="${options[key]}"`);
+    if (options[key]) {
+      attributes.push(`${key}="${options[key]}"`);
+    }
   });
 
   return attributes.join(' ');