Improve dev vs production distinctions

This commit is contained in:
Mars Hall
2018-12-16 11:35:55 -08:00
parent 8e0f4d44c6
commit d261bdfb76
2 changed files with 31 additions and 13 deletions

39
react-ui/src/App.js vendored
View File

@@ -8,17 +8,34 @@ class App extends Component {
<div className="App"> <div className="App">
<header className="App-header"> <header className="App-header">
<img src={logo} className="App-logo" alt="logo" /> <img src={logo} className="App-logo" alt="logo" />
<p> { process.env.NODE_ENV === 'production' ?
Edit <code>src/App.js</code> and save to reload.
</p> <p>
<a This is a production build from create-react-app
className="App-link" <br/>
href="https://reactjs.org" <br/>
target="_blank" <a
rel="noopener noreferrer" className="App-link"
> href="https://github.com/mars/heroku-cra-node"
Learn React >
</a> React + Node deployment on Heroku
</a>
</p>
: <p>
Edit <code>src/App.js</code> and save to reload.
<br/>
<br/>
<a
className="App-link"
href="https://reactjs.org"
target="_blank"
rel="noopener noreferrer"
>
Learn React
</a>
</p>
}
</header> </header>
</div> </div>
); );

View File

@@ -3,10 +3,11 @@ const path = require('path');
const cluster = require('cluster'); const cluster = require('cluster');
const numCPUs = require('os').cpus().length; const numCPUs = require('os').cpus().length;
const isDev = process.env.NODE_ENV !== 'production';
const PORT = process.env.PORT || 5000; const PORT = process.env.PORT || 5000;
// Multi-process to utilize all CPU cores. // Multi-process to utilize all CPU cores.
if (cluster.isMaster) { if (!isDev && cluster.isMaster) {
console.error(`Node cluster master ${process.pid} is running`); console.error(`Node cluster master ${process.pid} is running`);
// Fork workers. // Fork workers.
@@ -36,6 +37,6 @@ if (cluster.isMaster) {
}); });
app.listen(PORT, function () { app.listen(PORT, function () {
console.error(`Node cluster worker ${process.pid}: listening on port ${PORT}`); console.error(`Node ${isDev ? 'dev server' : 'cluster worker '+process.pid}: listening on port ${PORT}`);
}); });
} }