From ef4e3a2d9fb9ca7cc1c04eebccb290a020354207 Mon Sep 17 00:00:00 2001 From: Llewellyn Dsouza Date: Tue, 8 Mar 2022 08:03:20 +0530 Subject: [PATCH 01/16] Fix: eslint config --- .eslintrc.js | 6 +++++- package.json | 2 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.eslintrc.js b/.eslintrc.js index 72115e8..82682b6 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -8,6 +8,10 @@ module.exports = { extends: ['eslint:recommended', 'plugin:react/recommended'], parser: '@babel/eslint-parser', parserOptions: { + requireConfigFile: false, + babelOptions: { + presets: ['@babel/preset-react'] + }, ecmaFeatures: { jsx: true, modules: true, @@ -23,7 +27,7 @@ module.exports = { 'linebreak-style': ['error', 'unix'], quotes: ['warn', 'single'], semi: ['warn', 'always'], - 'no-unused-vars' : 'warn', + 'no-unused-vars': 'warn', 'comma-dangle': [ 'warn', { diff --git a/package.json b/package.json index 11b1bc4..9762331 100644 --- a/package.json +++ b/package.json @@ -100,7 +100,9 @@ ] }, "devDependencies": { + "@babel/core": "^7.17.5", "@babel/eslint-parser": "^7.17.0", + "@babel/preset-react": "^7.16.7", "eslint": "^8.2.0", "eslint-config-airbnb": "^19.0.4", "eslint-config-prettier": "8.3.0", From be258aea3409826e21d6835aa62344f6f80d7948 Mon Sep 17 00:00:00 2001 From: Llewellyn D'souza Date: Tue, 8 Mar 2022 16:08:08 +0530 Subject: [PATCH 02/16] Fixed: dropdown component --- src/components/Dropdown/index.js | 37 ++++++++------------------------ 1 file changed, 9 insertions(+), 28 deletions(-) diff --git a/src/components/Dropdown/index.js b/src/components/Dropdown/index.js index f512550..f113dc6 100644 --- a/src/components/Dropdown/index.js +++ b/src/components/Dropdown/index.js @@ -14,22 +14,8 @@ const useStyles = makeStyles({ } }); -export default function Dropdown({ dropdownData, label, dropdownChange = null }) { +export default function Dropdown({ dropdownData, label, onChange, value }) { const classes = useStyles(); - const [age, setAge] = useState(''); - - const handleChange = (event) => { - if (dropdownChange !== null) { - dropdownChange(event); - } - const { - target: { value } - } = event; - setAge( - // On autofill we get a stringified value. - typeof value === 'string' ? value.split(',') : value - ); - }; return ( <> @@ -40,22 +26,16 @@ export default function Dropdown({ dropdownData, label, dropdownChange = null }) - + Widget family L1 {primaryFamilies && @@ -203,8 +202,7 @@ function ItemListing() { + + None Selected + {inventoryTypes && inventoryTypes.map((inventory) => ( diff --git a/src/pages/newWarehouseDetails/index.js b/src/pages/newWarehouseDetails/index.js index d5cb94a..4f7cbcf 100644 --- a/src/pages/newWarehouseDetails/index.js +++ b/src/pages/newWarehouseDetails/index.js @@ -197,7 +197,7 @@ function NewWarehouseDetails() { ); }} > - + None Selected {inventoryTypes &&