mohiit1502/Automata
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(core): Port external secrets config (no-changelog) (#10094)

Browse Source
This commit is contained in:
Iván Ovejero
2024-07-18 10:52:41 +02:00
committed by GitHub
parent a04c4335da
commit 1f420e0bd6
4 changed files with 20 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/@n8n/config/src/configs/external-secrets.ts Normal file
View File

@@ -0,0 +1,12 @@
import { Config, Env } from '../decorators';
@Config
export class ExternalSecretsConfig {
/** How often (in seconds) to check for secret updates */
@Env('N8N_EXTERNAL_SECRETS_UPDATE_INTERVAL')
readonly updateInterval: number = 300;
/** Whether to prefer GET over LIST when fetching secrets from Hashicorp Vault */
@Env('N8N_EXTERNAL_SECRETS_PREFER_GET')
readonly preferGet: boolean = false;
}

4
packages/@n8n/config/src/index.ts
View File

@@ -4,6 +4,7 @@ import { DatabaseConfig } from './configs/database';
import { EmailConfig } from './configs/email';
import { VersionNotificationsConfig } from './configs/version-notifications';
import { PublicApiConfig } from './configs/public-api';
import { ExternalSecretsConfig } from './configs/external-secrets';
@Config
class UserManagementConfig {
@@ -27,4 +28,7 @@ export class GlobalConfig {
@Nested
publicApi: PublicApiConfig;
@Nested
externalSecrets: ExternalSecretsConfig;
}

7
packages/cli/src/ExternalSecrets/externalSecretsHelper.ee.ts
View File

@@ -1,9 +1,10 @@
import { License } from '@/License';
import config from '@/config';
import { GlobalConfig } from '@n8n/config';
import Container from 'typedi';
export const updateIntervalTime = () => config.getEnv('externalSecrets.updateInterval') * 1000;
export const preferGet = () => config.getEnv('externalSecrets.preferGet');
export const updateIntervalTime = () =>
Container.get(GlobalConfig).externalSecrets.updateInterval * 1000;
export const preferGet = () => Container.get(GlobalConfig).externalSecrets.preferGet;
export function isExternalSecretsEnabled() {
const license = Container.get(License);

15
packages/cli/src/config/schema.ts
View File

@@ -763,21 +763,6 @@ export const schema = {
},
},
externalSecrets: {
updateInterval: {
format: Number,
default: 300,
env: 'N8N_EXTERNAL_SECRETS_UPDATE_INTERVAL',
doc: 'How often (in seconds) to check for secret updates.',
},
preferGet: {
format: Boolean,
default: false,
env: 'N8N_EXTERNAL_SECRETS_PREFER_GET',
doc: 'Whether to prefer GET over LIST when fetching secrets from Hashicorp Vault.',
},
},
deployment: {
type: {
format: String,