mohiit1502/Automata
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(core): Remove inferral of execution status (no-changelog) (#9829)

Browse Source
This commit is contained in:
Iván Ovejero
2024-06-21 10:47:28 +02:00
committed by GitHub
parent f0ee0a1655
commit b5923020d7
2 changed files with 0 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/cli/src/executions/execution.service.ts
View File

@@ -9,7 +9,6 @@ import type {
ExecutionStatus,
} from 'n8n-workflow';
import {
ErrorReporterProxy as EventReporter,
ApplicationError,
ExecutionStatusList,
Workflow,
@@ -27,7 +26,6 @@ import { NodeTypes } from '@/NodeTypes';
import { Queue } from '@/Queue';
import type { ExecutionRequest, ExecutionSummaries } from './execution.types';
import { WorkflowRunner } from '@/WorkflowRunner';
import { getStatusUsingPreviousExecutionStatusMethod } from './executionHelpers';
import type { IGetExecutionsQueryFilter } from '@db/repositories/execution.repository';
import { ExecutionRepository } from '@db/repositories/execution.repository';
import { WorkflowRepository } from '@db/repositories/workflow.repository';
@@ -111,12 +109,6 @@ export class ExecutionService {
return undefined;
}
if (!execution.status) {
const { data, workflowData, ...rest } = execution;
EventReporter.info('Detected `null` execution status', { extra: { execution: rest } });
execution.status = getStatusUsingPreviousExecutionStatusMethod(execution);
}
return execution;
}

18
packages/cli/src/executions/executionHelpers.ts
View File

@@ -1,18 +0,0 @@
import type { ExecutionStatus } from 'n8n-workflow';
import type { IExecutionFlattedDb, IExecutionResponse } from '@/Interfaces';
export function getStatusUsingPreviousExecutionStatusMethod(
execution: IExecutionFlattedDb | IExecutionResponse,
): ExecutionStatus {
if (execution.waitTill) {
return 'waiting';
} else if (execution.stoppedAt === undefined) {
return 'running';
} else if (execution.finished) {
return 'success';
} else if (execution.stoppedAt !== null) {
return 'error';
} else {
return 'unknown';
}
}