Commit Graph

87 Commits

Author SHA1 Message Date
कारतोफ्फेलस्क्रिप्ट™
0faf46f4f8 refactor(core): Move instanceRole to InstanceSettings (no-changelog) (#10242) 2024-08-02 15:18:33 +02:00
Iván Ovejero
a533916628 refactor(core): Decouple post workflow execute event from internal hooks (no-changelog) (#10280) 2024-08-02 12:05:06 +02:00
Iván Ovejero
3e96b29332 fix(core): Restore log event n8n.workflow.failed (#10253) 2024-07-31 12:22:52 +02:00
Iván Ovejero
99dc56c7a1 refactor(core): Make instance role clearer (no-changelog) (#10188) 2024-07-30 10:20:21 +02:00
Iván Ovejero
d887c82d80 fix(core): Support execution recovery when saving execution progress (#10104) 2024-07-22 13:59:40 +02:00
Iván Ovejero
aba1c64500 refactor(core): Rename EventRelay to EventService (no-changelog) (#10110) 2024-07-19 12:55:38 +02:00
कारतोफ्फेलस्क्रिप्ट™
36b314d031 fix(core): Stopping an execution should reject any response promises (#9992) 2024-07-16 19:25:20 +02:00
Iván Ovejero
7e972c78af fix(core): Clear active execution on cancellation in scaling mode (#9979) 2024-07-09 17:09:39 +02:00
कारतोफ्फेलस्क्रिप्ट™
c7d4b471c4 refactor(core): Move backend config to a separate package (no-changelog) (#9325) 2024-07-05 11:43:27 +02:00
Iván Ovejero
e613de28ca fix(core): Fix execution cancellation in scaling mode (#9841) 2024-06-28 20:05:09 +02:00
Iván Ovejero
b5923020d7 refactor(core): Remove inferral of execution status (no-changelog) (#9829) 2024-06-21 10:47:28 +02:00
Iván Ovejero
199dff4fb3 refactor(core): Decouple event bus from internal hooks (no-changelog) (#9724) 2024-06-20 12:32:22 +02:00
कारतोफ्फेलस्क्रिप्ट™
65c5609ab5 feat(core): Use WebCrypto to generate all random numbers and strings (#9786) 2024-06-19 13:33:57 +02:00
Iván Ovejero
4131408e5e fix(core): Ensure execution recovery skips successful executions (#9793) 2024-06-19 09:45:50 +02:00
Iván Ovejero
c58621ab79 feat(core): Expand crash recovery to cover queue mode (#9676) 2024-06-18 15:22:02 +02:00
Iván Ovejero
7c358e5baa fix(core): Ensure followers do not recover executions from logs (#9785) 2024-06-18 10:52:38 +02:00
Iván Ovejero
cfef49e60a refactor(core): Include logless case in crash recovery (no-changelog) (#9725) 2024-06-13 12:54:51 +02:00
Iván Ovejero
6a43710859 refactor(core): Remove license from execution repository (no-changelog) (#9726) 2024-06-13 11:43:21 +02:00
Iván Ovejero
797342343f perf(core): Introduce concurrency control for main mode (#9453) 2024-06-12 15:05:43 +02:00
Iván Ovejero
b8338e3610 refactor(core): Revamp crash recovery mechanism for main mode (#9613) 2024-06-07 16:19:59 +02:00
Iván Ovejero
411ffbda7f fix(core): Ensure ID is a positive integer when fetching execution (#9629) 2024-06-05 13:05:07 +02:00
Iván Ovejero
1cb6c12b4f refactor(core): Track potentially unneeded inferral of execution status (no-changelog) (#9476) 2024-05-22 16:42:06 +02:00
Iván Ovejero
a217866cef fix(core): Account for retry of execution aborted by pre-execute hook (#9474) 2024-05-22 15:22:07 +02:00
Csaba Tuncsik
596c472ecc feat: RBAC (#8922)
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Valya Bullions <valya@n8n.io>
Co-authored-by: Danny Martini <danny@n8n.io>
Co-authored-by: Danny Martini <despair.blue@gmail.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: oleg <me@olegivaniv.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Elias Meire <elias@meire.dev>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Ayato Hayashi <go12limchangyong@gmail.com>
2024-05-17 10:53:15 +02:00
Alex Grozav
a3eea3ac5e feat(editor): Refactor and unify executions views (no-changelog) (#8538) 2024-04-19 07:50:18 +02:00
Iván Ovejero
69807a5efb refactor(core): Unify failed and error execution status (no-changelog) (#8943) 2024-03-25 17:52:07 +01:00
कारतोफ्फेलस्क्रिप्ट™
db4a419c8d refactor(core): Enforce authorization by default on all routes (no-changelog) (#8762) 2024-02-28 17:02:18 +01:00
Iván Ovejero
238b54c77b fix(core): Fix stopping and retrying failed executions (#8480) 2024-01-29 16:34:58 +01:00
कारतोफ्फेलस्क्रिप्ट™
c70fa66e76 refactor(core): Use DI for WorkflowRunner (no-changelog) (#8372) 2024-01-26 13:49:39 +01:00
कारतोफ्फेलस्क्रिप्ट™
d6deceacde refactor(core): Remove roleId indirection (no-changelog) (#8413) 2024-01-24 13:38:57 +01:00
Iván Ovejero
c0bc94c78f refactor(core): Finish removing UserManagementHelper (no-changelog) (#8418) 2024-01-23 13:58:31 +01:00
Iván Ovejero
49b52c4f1d refactor(core): Bring active executions into executions controller (no-changelog) (#8371) 2024-01-23 09:48:50 +01:00
Tomi Turtiainen
9a1cc56806 fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) (#8363)
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-17 17:08:50 +02:00
Iván Ovejero
2eb829a6b4 refactor(core): Use DI in execution services (no-changelog) (#8358) 2024-01-17 15:42:19 +01:00
कारतोफ्फेलस्क्रिप्ट™
7cdbb424e3 refactor(core): Move methods from WorkflowHelpers into various workflow services (no-changelog) (#8348) 2024-01-17 10:16:13 +01:00
Iván Ovejero
7bb2d1799e refactor(core): Consolidate executions controllers (no-changelog) (#8349) 2024-01-16 16:52:21 +01:00
Iván Ovejero
420b4271a9 refactor(core): Move typeorm operators from Public API (no-changelog) (#8319) 2024-01-16 13:35:43 +01:00
Omar Ajoue
e1acb5911a refactor: Make execution IDs mandatory in BE (#8299)
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2024-01-16 09:53:17 +00:00
कारतोफ्फेलस्क्रिप्ट™
21788d9153 fix(core): Remove circular dependency in WorkflowService and ActiveWorkflowRunner (#8128)
## Summary
A circular dependency between `WorkflowService` and
`ActiveWorkflowRunner` is sometimes causing `this.activeWorkflowRunner`
to be `undefined` in `WorkflowService`.
Breaking this circular dependency should hopefully fix this issue.

## Related tickets and issues
#8122


## Review / Merge checklist
- [x] PR title and summary are descriptive
- [ ] Tests included
2023-12-21 17:37:08 +01:00
Iván Ovejero
9ac8825a67 refactor(core): Move error execution creation to execution service (no-changelog) (#8006)
Continue breaking down legacy helpers.

Note: `getUserById` is unused.
2023-12-21 14:15:46 +01:00
कारतोफ्फेलस्क्रिप्ट™
464b565283 ci: Remove unnecessary async/await, enable await-thenable linting rule (no-changelog) (#8076)
## Summary
We accidentally made some functions `async` in
https://github.com/n8n-io/n8n/pull/7846
This PR reverts that change. 

## Review / Merge checklist
- [x] PR title and summary are descriptive.
2023-12-19 13:52:42 +01:00
Iván Ovejero
73d400a1bf refactor(core): Inject dependencies into workflow services (no-changelog) (#8066)
Inject dependencies into workflow services (no-changelog)

Up next:

- ~~Make workflow services injectable~~ #8033
- ~~Inject dependencies into workflow services~~ (current)
- Consolidate workflow controllers into one
- Make workflow controller injectable
- Inject dependencies into workflow controller
2023-12-18 16:10:30 +01:00
Iván Ovejero
1e7a309e63 refactor(core): Make workflow services injectable (no-changelog) (#8033)
Refactor static workflow service classes into DI-compatible classes

Context: https://n8nio.slack.com/archives/C069HS026UF/p1702466571648889

Up next:
- Inject dependencies into workflow services
- Consolidate workflow controllers into one
- Make workflow controller injectable
- Inject dependencies into workflow controller

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-12-15 12:59:56 +01:00
Val
1cb92ffe16 feat: Replace owner checks with scope checks (no-changelog) (#7846)
Github issue / Community forum post (link here to close automatically):
2023-11-29 14:48:36 +00:00
Iván Ovejero
c08c5cc37b refactor(core): Switch plain errors in cli to ApplicationError (#7857)
Ensure all errors in `cli` are `ApplicationError` or children of it and
contain no variables in the message, to continue normalizing all the
errors we report to Sentry

Follow-up to: https://github.com/n8n-io/n8n/pull/7839
2023-11-29 12:25:10 +01:00
Iván Ovejero
1c6178759c refactor(core): Reorganize error hierarchy in cli package (no-changelog) (#7839)
Ensure all errors in `cli` inherit from `ApplicationError` to continue
normalizing all the errors we report to Sentry

Follow-up to: https://github.com/n8n-io/n8n/pull/7820
2023-11-28 10:19:27 +01:00
कारतोफ्फेलस्क्रिप्ट™
000e76e3b4 ci(core): Reduce memory usage in tests (part-2) (no-changelog) (#7671)
This also gets rid of `Db.collection`, which was another source of
circular dependencies.
2023-11-10 15:04:26 +01:00
कारतोफ्फेलस्क्रिप्ट™
5edf722209 ci: Stop disabling linting rules that are explicitly set to warn (no-changelog) (#7669) 2023-11-09 14:05:39 +01:00
Iván Ovejero
3a776e0132 refactor(core): Stop reporting to Sentry missing-node-on-retry error (no-changelog) (#7648)
https://n8nio.sentry.io/issues/4612370603
2023-11-08 10:09:33 +01:00
Iván Ovejero
62c096710f refactor: Run lintfix (no-changelog) (#7537)
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00